Skip to content

Rationale behind float16 and scipy pinning #555

@ivustianiu-illumina

Description

@ivustianiu-illumina

It seems that using float16 to store sparse TF-IDF vectors in entity linkers is the only reason for enforcing old scipy version which prevents package upgrades to modern Python if the linkers are needed.

But what is the rationale behind this except taking less space because it seems to be loaded back as float32? I assume many production use cases are OK with float32 so maybe we can select type based on the scipy version instead of hard limiting the version and raising an exception? I guess there are probably some backward compatibility considerations for keeping float16?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions