"nextmap" plugin fixes #1130
Open
"nextmap" plugin fixes #1130
+32
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revise the logic so the operation makes more sense and fixes ancient bugs - Remove the back-and-forth changing of the "mp_chattime" cvar, instead just deduct one second from it for the change task (with bounds checking, if mp_chattime is less than one including something stupid like a negative value, the map change will be immediate) - Add a list of mods known to not have a "mp_chattime" cvar but use a static time instead (Opposing Force, Ricochet, Gunman Chronicles each use 6 seconds) and set the chattime appropriately Also some QOL - Add "/nextmap", "/currentmap", "/ff" client say commands - Do not print the command itself to chat when someone uses it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise the logic so the operation makes more sense and fixes ancient bugs
Remove the error-prone back-and-forth changing of the "mp_chattime" cvar, instead just deduct one second from it for the change task (with bounds checking, if mp_chattime is less than one including something stupid like a negative value, the map change will be immediate)
Add a list of mods known to not have a "mp_chattime" cvar but use a static time instead (Opposing Force, Ricochet, Gunman Chronicles each use 6 seconds) and set the chattime appropriately. If the mod doesn't have a "mp_chattime" cvar nor is one of the aforementioned mods, change immediately.
Also some QOL