Remove circular reference in destructor

trowski · trowski · commit 1e1155d73db5 · 2019-09-30T17:38:49.000-05:00
diff --git a/src/PqUnbufferedResultSet.php b/src/PqUnbufferedResultSet.php
@@ -52,9 +52,10 @@ public function __destruct()
             return;
         }
 
-        asyncCall(function () {
+        $producer = $this->producer;
+        asyncCall(static function () use ($producer) {
             try {
-                while (yield $this->producer->advance());
+                while (yield $producer->advance());
             } catch (\Throwable $exception) {
                 // Ignore iterator failure when destroying.
             }

Original file line number	Diff line number	Diff line change
`@@ -52,9 +52,10 @@ public function __destruct()`
`52`	`52`	`return;`
`53`	`53`	`}`
`54`	`54`
`55`		`- asyncCall(function () {`
	`55`	`+ $producer = $this->producer;`
	`56`	`+ asyncCall(static function () use ($producer) {`
`56`	`57`	`try {`
`57`		`- while (yield $this->producer->advance());`
	`58`	`+ while (yield $producer->advance());`
`58`	`59`	`} catch (\Throwable $exception) {`
`59`	`60`	`// Ignore iterator failure when destroying.`
`60`	`61`	`}`