Add phpstan & fix some doc issues

trowski · trowski · commit f0f233b8aca2 · 2017-12-11T19:10:14.000-06:00
diff --git a/composer.json b/composer.json
@@ -24,7 +24,8 @@
     "require-dev": {
         "amphp/phpunit-util": "^1",
         "phpunit/phpunit": "^6",
-        "friendsofphp/php-cs-fixer": "^2.3"
+        "friendsofphp/php-cs-fixer": "^2.3",
+        "phpstan/phpstan": "^0.9"
     },
     "autoload": {
         "psr-4": {
diff --git a/lib/Internal/ReferenceQueue.php b/lib/Internal/ReferenceQueue.php
@@ -5,7 +5,7 @@
 use Amp\Loop;
 
 class ReferenceQueue {
-    /** @var callable[] */
+    /** @var callable[]|null */
     private $onDestruct = [];
 
     /** @var int */
diff --git a/lib/Listener.php b/lib/Listener.php
@@ -12,7 +12,7 @@ class Listener implements Iterator, Operation {
     /** @var string */
     private $channel;
 
-    /** @var callable */
+    /** @var callable|null */
     private $unlisten;
 
     /** @var \Amp\Postgres\Internal\ReferenceQueue */
diff --git a/lib/PgSqlResultSet.php b/lib/PgSqlResultSet.php
@@ -23,7 +23,6 @@ class PgSqlResultSet implements ResultSet {
      */
     public function __construct($handle) {
         $this->handle = $handle;
-        $this->numRows = \pg_num_rows($this->handle);
     }
 
     /**
diff --git a/lib/Transaction.php b/lib/Transaction.php
@@ -10,7 +10,7 @@ class Transaction implements Handle, Operation {
     const REPEATABLE   = 2;
     const SERIALIZABLE = 4;
 
-    /** @var \Amp\Postgres\Handle */
+    /** @var \Amp\Postgres\Handle|null */
     private $handle;
 
     /** @var int */

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@ class PgSqlResultSet implements ResultSet {`
`23`	`23`	`*/`
`24`	`24`	`public function __construct($handle) {`
`25`	`25`	`$this->handle = $handle;`
`26`		`- $this->numRows = \pg_num_rows($this->handle);`
`27`	`26`	`}`
`28`	`27`
`29`	`28`	`/**`