Skip to content

Commit 97c0df5

Browse files
committed
Add root password for mariadb container services in workflows
1 parent c719d1c commit 97c0df5

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

.github/workflows/build-test-measure.yml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -362,11 +362,10 @@ jobs:
362362
mysql:
363363
image: mariadb:latest
364364
env:
365-
MYSQL_ALLOW_EMPTY_PASSWORD: true
366-
MYSQL_ROOT_PASSWORD:
365+
MYSQL_ROOT_PASSWORD: password
367366
MYSQL_DATABASE: wordpress_test
368367
ports:
369-
- 3306
368+
- 3306:3306
370369
options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
371370
continue-on-error: ${{ matrix.experimental == true }}
372371
strategy:
@@ -542,7 +541,7 @@ jobs:
542541

543542
- name: Install WP tests
544543
if: needs.pre-run.outputs.changed-php-count > 0
545-
run: bash bin/ci/install-wp-tests.sh wordpress_test root '' 127.0.0.1:${{ job.services.mysql.ports['3306'] }} ${{ matrix.wp }} true
544+
run: bash bin/ci/install-wp-tests.sh wordpress_test root password 127.0.0.1:${{ job.services.mysql.ports['3306'] }} ${{ matrix.wp }} true
546545

547546
- name: Post install of WP tests
548547
if: needs.pre-run.outputs.changed-php-count > 0
@@ -606,8 +605,7 @@ jobs:
606605
mysql:
607606
image: mariadb:latest
608607
env:
609-
MYSQL_ALLOW_EMPTY_PASSWORD: true
610-
MYSQL_ROOT_PASSWORD:
608+
MYSQL_ROOT_PASSWORD: password
611609
MYSQL_DATABASE: wordpress_test
612610
ports:
613611
- 3306
@@ -703,7 +701,7 @@ jobs:
703701
echo "MYSQL_HOST=127.0.0.1" >> $GITHUB_ENV
704702
echo "MYSQL_TCP_PORT=${{ job.services.mysql.ports['3306'] }}" >> $GITHUB_ENV
705703
echo "WP_CLI_TEST_DBROOTUSER=root" >> $GITHUB_ENV
706-
echo "WP_CLI_TEST_DBROOTPASS=" >> $GITHUB_ENV
704+
echo "WP_CLI_TEST_DBROOTPASS=password" >> $GITHUB_ENV
707705
echo "WP_CLI_TEST_DBUSER=wp_cli_test" >> $GITHUB_ENV
708706
echo "WP_CLI_TEST_DBPASS=password1" >> $GITHUB_ENV
709707
echo "WP_CLI_TEST_DBHOST=127.0.0.1:${{ job.services.mysql.ports['3306'] }}" >> $GITHUB_ENV

0 commit comments

Comments
 (0)