[Storage] Flattened Client Refactor (Azure#3176)

Author: vincenttran-msft

eng/emitter-package-lock.json

@@ -1,17 +1,17 @@
 {
   "main": "dist/src/index.js",
   "dependencies": {
-    "@azure-tools/typespec-rust": "0.24.0"
+    "@azure-tools/typespec-rust": "0.24.1"
   },
   "devDependencies": {
-    "@azure-tools/typespec-azure-core": "0.60",
-    "@azure-tools/typespec-azure-rulesets": "0.60",
-    "@azure-tools/typespec-client-generator-core": "0.60",
-    "@typespec/compiler": "1.4",
-    "@typespec/http": "1.4",
-    "@typespec/openapi": "1.4",
-    "@typespec/rest": "0.74",
-    "@typespec/versioning": "0.74",
-    "@typespec/xml": "0.74"
+    "@azure-tools/typespec-azure-core": "~0.61",
+    "@azure-tools/typespec-azure-rulesets": "~0.61",
+    "@azure-tools/typespec-client-generator-core": ">=0.61.1",
+    "@typespec/compiler": "^1.4.0",
+    "@typespec/http": "^1.4.0",
+    "@typespec/openapi": "^1.4.0",
+    "@typespec/rest": "~0.75.0",
+    "@typespec/versioning": "~0.75.0",
+    "@typespec/xml": "~0.75.0"
   }
-}
+}

eng/emitter-package.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "rust",
   "TagPrefix": "rust/eventhubs",
-  "Tag": "rust/eventhubs_12266aa668"
+  "Tag": "rust/eventhubs_ad9b84912d"
 }

sdk/eventhubs/assets.json

@@ -88,8 +88,8 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let credential = DeveloperToolsCredential::new(None)?;
     let blob_client = BlobContainerClient::new(
         "https://yourstorageaccount.blob.core.windows.net",
-        "yourcontainername".to_string(),
-        credential.clone(),
+        "yourcontainername",
+        Some(credential.clone()),
         None,
     )?;
 

sdk/eventhubs/azure_messaging_eventhubs_checkpointstore_blob/README.md

@@ -46,8 +46,8 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     // Instantiate a blob client with OpenTelemetry instrumentation enabled
     let blob_container_client = BlobContainerClient::new(
         &storage_account_url,
-        container,
-        credential,
+        &container,
+        Some(credential),
         Some(BlobContainerClientOptions {
             client_options: ClientOptions {
                 instrumentation: InstrumentationOptions {

sdk/eventhubs/azure_messaging_eventhubs_checkpointstore_blob/examples/checkpoint_store_basic.rs

@@ -33,8 +33,8 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let credential = DeveloperToolsCredential::new(None)?;
     let blob_container_client = BlobContainerClient::new(
         &storage_account_url,
-        container_name,
-        credential.clone(),
+        &container_name,
+        Some(credential.clone()),
         None,
     )?;
     let consumer = ConsumerClient::builder()

sdk/eventhubs/azure_messaging_eventhubs_checkpointstore_blob/examples/processor_with_blob_checkpoints.rs

@@ -68,9 +68,7 @@ impl BlobCheckpointStore {
         blob_name: &str,
         metadata: HashMap<String, String>,
     ) -> Result<(Option<OffsetDateTime>, Option<Etag>)> {
-        let blob_client = self
-            .blob_container_client
-            .blob_client(blob_name.to_string());
+        let blob_client = self.blob_container_client.blob_client(blob_name);
 
         let result = blob_client.set_metadata(metadata.clone(), None).await;
         match result {
@@ -106,9 +104,7 @@ impl BlobCheckpointStore {
         metadata: Option<HashMap<String, String>>,
         etag: Option<Etag>,
     ) -> Result<(Option<OffsetDateTime>, Option<Etag>)> {
-        let blob_client = self
-            .blob_container_client
-            .blob_client(blob_name.to_string());
+        let blob_client = self.blob_container_client.blob_client(blob_name);
 
         if etag.is_some() {
             debug!(

sdk/eventhubs/azure_messaging_eventhubs_checkpointstore_blob/src/checkpoint_store.rs

@@ -17,8 +17,8 @@ pub fn create_test_checkpoint_store(recording: &Recording) -> Result<Arc<BlobChe
     recording.instrument(&mut options.client_options);
     let blob_container_client = BlobContainerClient::new(
         &recording.var("AZURE_STORAGE_BLOB_ENDPOINT", None),
-        recording.var("AZURE_STORAGE_BLOB_CONTAINER", None),
-        credential.clone(),
+        &recording.var("AZURE_STORAGE_BLOB_CONTAINER", None),
+        Some(credential),
         Some(options),
     )?;
 

sdk/eventhubs/azure_messaging_eventhubs_checkpointstore_blob/tests/checkpoint_unit_tests.rs

@@ -4,6 +4,7 @@ appendpos
 blockid
 blocklist
 blocklisttype
+Btext
 copyid
 deletedwithversions
 deletetype
@@ -12,7 +13,9 @@ immutabilitypolicy
 incrementalcopy
 legalhold
 missingcontainer
+numofmessages
 pagelist
+peekonly
 policyid
 prevsnapshot
 RAGRS
@@ -27,5 +30,3 @@ testcontainer
 uncommittedblobs
 westus
 yourtagname
-numofmessages
-peekonly

sdk/storage/.dict.txt

@@ -4,8 +4,21 @@
 
 ### Features Added
 
+- Added support for client construction directly from URLs:
+  - `AppendBlobClient::from_url()`
+  - `BlobClient::from_url()`
+  - `BlobContainerClient::from_url()`
+  - `BlockBlobClient::from_url()`
+  - `PageBlobClient::from_url()`
+- Added support for SAS (shared access signature) URLs via the new `from_url()` methods.
+
 ### Breaking Changes
 
+- Removed the `container_name()` and `blob_name()` accessors on relevant clients.
+- Removed the `endpoint` struct field on all clients, as this value is now returned directly from the underlying generated client.
+- Changed the `container_name` and `blob_name` parameters from owned `String` to `&str` reference on relevant client constructor methods (`new()`).
+- The `credential` parameter is now `Optional` on `new()` client constructors, allowing for construction of public access clients.
+
 ### Bugs Fixed
 
 ### Other Changes