Skip to content

Commit 2160a86

Browse files
committed
fix(nf): make schematic use forward slashes for paths even thoug it runs on windows
1 parent 4db7e9e commit 2160a86

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

libs/native-federation-core/src/lib/core/bundle-exposed-and-mappings.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export interface ArtefactInfo {
2020
export async function bundleExposedAndMappings(
2121
config: NormalizedFederationConfig,
2222
fedOptions: FederationOptions,
23-
externals: string[],
23+
externals: string[]
2424
): Promise<ArtefactInfo> {
2525
const shared = config.sharedMappings.map((sm) => {
2626
const entryPoint = sm.path;

libs/native-federation/src/builders/build/schema.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
"properties": {
7171
"enable": {
7272
"type": "boolean",
73-
"default": false,
73+
"default": true,
7474
"description": "Enable build completion notifications for local development. It will send events to notify when the federation build is complete."
7575
},
7676
"endpoint": {

libs/native-federation/src/schematics/init/schematic.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,8 @@ export default function config(options: MfSchematicSchema): Rule {
105105

106106
const exists = tree.exists(federationConfigPath);
107107

108-
const cand1 = path.join(projectSourceRoot, 'app', 'app.component.ts');
109-
const cand2 = path.join(projectSourceRoot, 'app', 'app.ts');
108+
const cand1 = path.join(projectSourceRoot, 'app', 'app.component.ts').replace(/\\/g, '/');
109+
const cand2 = path.join(projectSourceRoot, 'app', 'app.ts').replace(/\\/g, '/');
110110

111111
const appComponent = tree.exists(cand1)
112112
? cand1

0 commit comments

Comments
 (0)