Skip to content

Commit 79637e5

Browse files
author
Alain Sollberger
committed
feat(skip-list)
- using preparedSkipList for secondaries - removed constant PREPARED_DEFAULT_SKIP_LIST - reverted package.json changes
1 parent 980604c commit 79637e5

File tree

5 files changed

+12881
-11140
lines changed

5 files changed

+12881
-11140
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,5 +47,6 @@ migrations.json
4747
# Angular
4848
.angular
4949

50+
.nx
5051
.cursor/rules/nx-rules.mdc
5152
.github/instructions/nx.instructions.md

libs/native-federation-core/src/lib/config/share-utils.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { SharedConfig } from './federation-config';
55
import {
66
DEFAULT_SKIP_LIST,
77
isInSkipList,
8-
PREPARED_DEFAULT_SKIP_LIST,
98
PreparedSkipList,
109
prepareSkipList,
1110
SkipList,
@@ -129,7 +128,7 @@ function _findSecondaries(
129128
continue;
130129
}
131130

132-
if (isInSkipList(secondaryLibName, PREPARED_DEFAULT_SKIP_LIST)) {
131+
if (isInSkipList(secondaryLibName, preparedSkipList)) {
133132
continue;
134133
}
135134

libs/native-federation-core/src/lib/core/default-skip-list.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ export const DEFAULT_SKIP_LIST: SkipList = [
2828
// (pkg) => pkg.startsWith('@angular/common/locales'),
2929
];
3030

31-
export const PREPARED_DEFAULT_SKIP_LIST = prepareSkipList(DEFAULT_SKIP_LIST);
32-
3331
export type PreparedSkipList = {
3432
strings: Set<string>;
3533
functions: SkipFn[];

0 commit comments

Comments
 (0)