Skip to content

fix(skip-list): fixed the handling and passing of the skip list #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 27, 2025
Merged

fix(skip-list): fixed the handling and passing of the skip list #902

merged 9 commits into from
Oct 27, 2025

Conversation

@asollberger
Copy link

  • the skip list was ignored for secondary entry points, and thus libraries were brought back in (libs/native-federation-core/src/lib/config/share-utils.ts)
  • fixed a few typos

fix(skip-list): fixed the handling and passing of the skip list
cc4cd6c 
- the skip list was ignored for secondary entry points, and thus libraries were brought back in (libs/native-federation-core/src/lib/config/share-utils.ts)
- fixed a few typos
@asollberger asollberger mentioned this pull request Jul 22, 2025
Closed
2 tasks
Aukevanoost
Aukevanoost requested changes Oct 2, 2025
View reviewed changes
Copy link
Collaborator

@Aukevanoost Aukevanoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the cleanup but what are you trying to solve? I do agree that it is a bit cleaner but I do have some questions.

Could you take a look at that?

Aukevanoost
Aukevanoost requested changes Oct 3, 2025
View reviewed changes
Alain Sollberger added 5 commits October 27, 2025 08:44
Merge branch 'main' into bug/skip-list
6d2e598
feat(merge): merged latest changes
980604c
feat(skip-list)
79637e5 
- using preparedSkipList for secondaries
- removed constant PREPARED_DEFAULT_SKIP_LIST
- reverted package.json changes
feat(skip-list)
56f18f4 
- using preparedSkipList for secondaries
- removed constant PREPARED_DEFAULT_SKIP_LIST
- reverted package.json changes
fix(lint): fixed lint errors
240d7ad
@asollberger
Copy link
Author

@Aukevanoost Thanks for the review. I fixed the remaining issues and cleaned up the unnecessary files.

The PR is now finally building again.

@Aukevanoost
Copy link
Collaborator

Great! Thanks! I'll have a look

Aukevanoost
Aukevanoost approved these changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@Aukevanoost Aukevanoost left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution and for fixing the PR issues!

@Aukevanoost Aukevanoost merged commit bf4393e into angular-architects:main Oct 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aukevanoost Aukevanoost Aukevanoost approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asollberger @Aukevanoost