fix: filter undefined and null from all object refs

Author: nartc

libs/angular-three-cannon/services/src/lib/body.ts

@@ -26,6 +26,7 @@ import { NgtcStore, NgtcUtils } from 'angular-three-cannon';
 import { NGTC_DEBUG_API } from 'angular-three-cannon/debug';
 import { combineLatest, Observable, Subscription } from 'rxjs';
 import * as THREE from 'three';
+import { filterEmpty } from './utils';
 
 export type NgtcAtomicApi<K extends AtomicName> = {
     set: (value: AtomicProps[K]) => void;
@@ -191,7 +192,7 @@ function injectBody<TBodyProps extends BodyProps, TObject extends THREE.Object3D
     });
 
     // start the pipeline as soon as bodyRef has a truthy value
-    subscription = combineLatest([physicsStore.select('worker'), bodyRef.$])
+    subscription = combineLatest([physicsStore.select('worker'), bodyRef.$.pipe(filterEmpty())])
         .pipe(
             tapEffect(([worker, object]) => {
                 const currentWorker = worker;

libs/angular-three-cannon/services/src/lib/constraint.ts

@@ -11,6 +11,7 @@ import {
 import { injectNgtDestroy, injectNgtRef, is, makeId, NgtInjectedRef, tapEffect } from 'angular-three';
 import { NgtcStore } from 'angular-three-cannon';
 import { combineLatest, takeUntil } from 'rxjs';
+import { filterEmpty } from './utils';
 
 export interface NgtcConstraintApi {
     disable: () => void;
@@ -122,7 +123,7 @@ function injectConstraint<
     const bodyARef = !is.ref(bodyA) ? injectNgtRef(bodyA) : bodyA;
     const bodyBRef = !is.ref(bodyB) ? injectNgtRef(bodyB) : bodyB;
 
-    combineLatest([physicsStore.select('worker'), bodyARef.$, bodyBRef.$])
+    combineLatest([physicsStore.select('worker'), bodyARef.$.pipe(filterEmpty()), bodyBRef.$.pipe(filterEmpty())])
         .pipe(
             tapEffect(([worker, bodyA, bodyB]) => {
                 const opts = optsFn();

libs/angular-three-cannon/services/src/lib/raycast-vehicle.ts

@@ -4,6 +4,7 @@ import { injectNgtDestroy, injectNgtRef, NgtInjectedRef, tapEffect } from 'angul
 import { NgtcStore, NgtcUtils } from 'angular-three-cannon';
 import { combineLatest, takeUntil } from 'rxjs';
 import * as THREE from 'three';
+import { filterEmpty } from './utils';
 
 export interface NgtcRaycastVehicleProps {
     chassisBody: NgtInjectedRef<THREE.Object3D>;
@@ -45,7 +46,12 @@ export function injectRaycastVehicle<TObject extends THREE.Object3D = THREE.Obje
     queueMicrotask(() => {
         const { chassisBody, indexForwardAxis = 2, indexRightAxis = 0, indexUpAxis = 1, wheelInfos, wheels } = fn();
 
-        combineLatest([store.select('worker'), ref.$, chassisBody.$, ...wheels.map((wheel) => wheel.$)])
+        combineLatest([
+            store.select('worker'),
+            ref.$.pipe(filterEmpty()),
+            chassisBody.$.pipe(filterEmpty()),
+            ...wheels.map((wheel) => wheel.$.pipe(filterEmpty())),
+        ])
             .pipe(
                 tapEffect(([worker, object]) => {
                     const uuid = object.uuid;

libs/angular-three-cannon/services/src/lib/spring.ts

@@ -3,6 +3,7 @@ import { SpringOptns } from '@pmndrs/cannon-worker-api';
 import { injectNgtDestroy, makeId, NgtInjectedRef, tapEffect } from 'angular-three';
 import { NgtcStore } from 'angular-three-cannon';
 import { combineLatest, takeUntil } from 'rxjs';
+import { filterEmpty } from './utils';
 
 export interface NgtcSpringApi {
     setDamping: (value: number) => void;
@@ -32,7 +33,7 @@ export function injectSpring<
     const uuid = makeId();
     const { destroy$ } = injectNgtDestroy();
 
-    combineLatest([store.select('worker'), bodyA.$, bodyB.$])
+    combineLatest([store.select('worker'), bodyA.$.pipe(filterEmpty()), bodyB.$.pipe(filterEmpty())])
         .pipe(
             tapEffect(([worker, bodyA, bodyB]) => {
                 const opts = optsFn();

libs/angular-three-cannon/services/src/lib/utils.ts

@@ -0,0 +1,5 @@
+import { filter, MonoTypeOperatorFunction } from 'rxjs';
+
+export function filterEmpty<T>(): MonoTypeOperatorFunction<T> {
+    return filter<T>((obj): obj is T => obj != null);
+}