Skip to content

Commit 160fdcf

Browse files
committed
ci: transfer PR package artifact storage to GHA
The newly introduce GHA CI build job has been augmented to build the release packages and, when run within a PR, upload the release packages at an artifact within the PR.
1 parent 2a4d878 commit 160fdcf

File tree

2 files changed

+10
-25
lines changed

2 files changed

+10
-25
lines changed

.circleci/dynamic_config.yml

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -265,24 +265,6 @@ jobs:
265265
command: yarn admin snapshots --verbose
266266
- fail_fast
267267

268-
publish_artifacts:
269-
executor: action-executor
270-
resource_class: medium
271-
environment:
272-
steps:
273-
- custom_attach_workspace
274-
- run:
275-
name: Create artifacts for packages
276-
command: yarn ng-dev release build
277-
- run:
278-
name: Copy tarballs to folder
279-
command: |
280-
mkdir -p dist/artifacts/
281-
cp dist/releases/*.tgz dist/artifacts/
282-
- store_artifacts:
283-
path: dist/artifacts/
284-
destination: angular
285-
286268
# Windows jobs
287269
e2e-cli-win:
288270
executor: windows-executor
@@ -399,8 +381,3 @@ workflows:
399381
requires:
400382
- setup
401383
- e2e-cli
402-
403-
- publish_artifacts:
404-
<<: *only_pull_requests
405-
requires:
406-
- build

.github/workflows/ci.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ jobs:
5151
# it has been merged.
5252
if: github.event_name == 'pull_request'
5353
run: yarn ng-dev format changed --check ${{ github.event.pull_request.base.sha }}
54+
5455
build:
5556
runs-on: ubuntu-latest
5657
steps:
@@ -62,8 +63,15 @@ jobs:
6263
uses: angular/dev-infra/github-actions/bazel/configure-remote@0109d498b0f6aae418ed4924a5e5c65695f0ac61
6364
- name: Install node modules
6465
run: yarn install --frozen-lockfile
65-
- name: Build all buildable targets
66-
run: yarn bazel build //...
66+
- name: Build release targets
67+
run: yarn ng-dev release build
68+
- name: Store PR release packages
69+
if: github.event_name == 'pull_request'
70+
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2
71+
with:
72+
name: packages
73+
path: dist/releases/*.tgz
74+
retention-days: 14
6775

6876
test:
6977
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)