test: use node:assert in basic and build E2E tests

Replaces error throwing with Node.js assertions in E2E tests.
This provides more informative error messages when tests fail.

Author: clydin

tests/legacy-cli/e2e/tests/basic/rebuild.ts

@@ -1,3 +1,4 @@
+import assert from 'node:assert/strict';
 import { setTimeout } from 'node:timers/promises';
 import { getGlobalVariable } from '../../utils/env';
 import { appendToFile, replaceInFile, writeMultipleFiles } from '../../utils/fs';
@@ -68,15 +69,9 @@ export default async function () {
   {
     const response = await fetch(`http://localhost:${port}/main.js`);
     const body = await response.text();
-    if (!body.match(/\$\$_E2E_GOLDEN_VALUE_1/)) {
-      throw new Error('Expected golden value 1.');
-    }
-    if (!body.match(/\$\$_E2E_GOLDEN_VALUE_2/)) {
-      throw new Error('Expected golden value 2.');
-    }
-    if (!body.match(/\$\$_E2E_GOLDEN_VALUE_3/)) {
-      throw new Error('Expected golden value 3.');
-    }
+    assert.match(body, /\$\$_E2E_GOLDEN_VALUE_1/);
+    assert.match(body, /\$\$_E2E_GOLDEN_VALUE_2/);
+    assert.match(body, /\$\$_E2E_GOLDEN_VALUE_3/);
   }
 
   await setTimeout(500);
@@ -90,9 +85,7 @@ export default async function () {
   {
     const response = await fetch(`http://localhost:${port}/main.js`);
     const body = await response.text();
-    if (!body.match(/testingTESTING123/)) {
-      throw new Error('Expected component HTML to update.');
-    }
+    assert.match(body, /testingTESTING123/);
   }
 
   await setTimeout(500);
@@ -106,9 +99,7 @@ export default async function () {
   {
     const response = await fetch(`http://localhost:${port}/main.js`);
     const body = await response.text();
-    if (!body.match(/color:\s?blue/)) {
-      throw new Error('Expected component CSS to update.');
-    }
+    assert.match(body, /color:\s?blue/);
   }
 
   await setTimeout(500);
@@ -122,8 +113,6 @@ export default async function () {
   {
     const response = await fetch(`http://localhost:${port}/styles.css`);
     const body = await response.text();
-    if (!body.match(/color:\s?green/)) {
-      throw new Error('Expected global CSS to update.');
-    }
+    assert.match(body, /color:\s?green/);
   }
 }

tests/legacy-cli/e2e/tests/basic/serve.ts

@@ -1,3 +1,4 @@
+import assert from 'node:assert/strict';
 import { killAllProcesses } from '../../utils/process';
 import { ngServe } from '../../utils/project';
 
@@ -14,14 +15,8 @@ export default async function () {
 
 async function verifyResponse(port: number): Promise<void> {
   const indexResponse = await fetch(`http://localhost:${port}/`);
-
-  if (!/<app-root><\/app-root>/.test(await indexResponse.text())) {
-    throw new Error('Response does not match expected value.');
-  }
+  assert.match(await indexResponse.text(), /<app-root><\/app-root>/);
 
   const assetResponse = await fetch(`http://localhost:${port}/favicon.ico`);
-
-  if (!assetResponse.ok) {
-    throw new Error('Expected favicon asset to be available.');
-  }
+  assert(assetResponse.ok, 'Expected favicon asset to be available.');
 }

tests/legacy-cli/e2e/tests/basic/styles-array.ts

@@ -1,3 +1,4 @@
+import assert from 'node:assert/strict';
 import { expectFileToMatch, writeMultipleFiles } from '../../utils/fs';
 import { ng } from '../../utils/process';
 import { updateJsonFile } from '../../utils/project';
@@ -42,8 +43,5 @@ export default async function () {
   );
 
   // Non injected styles should be listed under lazy chunk files
-  if (!/Lazy chunk files[\s\S]+renamed-lazy-style\.css/m.test(stdout)) {
-    console.log(stdout);
-    throw new Error(`Expected "renamed-lazy-style.css" to be listed under "Lazy chunk files".`);
-  }
+  assert.match(stdout, /Lazy chunk files[\s\S]+renamed-lazy-style\.css/m);
 }