Skip to content

Commit 89af7a8

Browse files
committed
Use base ref instead of base sha.
1 parent 6e279c9 commit 89af7a8

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

.github/workflows/_shared-docs-build-pr.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,12 @@ jobs:
303303
- name: Checkout BASE
304304
uses: actions/checkout@v4
305305
with:
306-
ref: ${{ github.event.pull_request.base.sha }}
306+
# Use base.ref, not base.sha, to make sure we do not get a checkout of the base at an earlier time
307+
# (when the PR's branch was branched off the PR's target branch), but right now. Without this there
308+
# will be a potentially large list of changes since the merge commit we check out for HEAD is based
309+
# on a far newer version. I'm not 100% sure whether this is also a good idea for the closed event
310+
# though...
311+
ref: ${{ github.event.pull_request.base.ref }}
307312
path: ${{ steps.vars.outputs.checkout-path }}
308313
persist-credentials: false
309314

0 commit comments

Comments
 (0)