Remove argument

Author: Andersson007

.config/pydoclint-baseline.txt

@@ -333,6 +333,7 @@ src/ansible_navigator/ui_framework/ui.py
 --------------------
 src/ansible_navigator/ui_framework/ui_config.py
     DOC601: Class `UIConfig`: Class docstring contains fewer class attributes than actual class attributes.  (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.)
+    DOC603: Class `UIConfig`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [color: bool, colors_initialized: bool, grammar_dir: Traversable, osc4: bool, terminal_colors_path: Traversable, theme_path: Traversable]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.)
 --------------------
 src/ansible_navigator/ui_framework/ui_constants.py
     DOC601: Class `Color`: Class docstring contains fewer class attributes than actual class attributes.  (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.)

src/ansible_navigator/action_runner.py

@@ -67,7 +67,6 @@ def initialize_ui(self, refresh: int) -> None:
             osc4=self._args.osc4,
             terminal_colors_path=TERMINAL_COLORS_PATH,
             theme_path=THEME_PATH,
-            cursor_navigation=bool(getattr(self._args, "cursor_navigation", False)),
         )
         self._logger.debug("grammar path = %s", config.grammar_dir)
         self._logger.debug("theme path = %s", config.theme_path)

src/ansible_navigator/configuration_subsystem/navigator_configuration.py

@@ -316,15 +316,6 @@ class Internals:
             value=SettingsEntryValue(),
             version_added="v2.0",
         ),
-        SettingsEntry(
-            name="cursor_navigation",
-            choices=[True, False],
-            cli_parameters=CliParameters(short="--cn", action="store_true"),
-            settings_file_path_override="ui.cursor-navigation",
-            short_description="Enable arrow-key cursor navigation and Enter selection in menus",
-            value=SettingsEntryValue(default=False),
-            version_added="v2.5",
-        ),
         SettingsEntry(
             name="display_color",
             change_after_initial=False,

src/ansible_navigator/data/ansible-navigator.json

@@ -518,29 +518,14 @@
                     "default": "UTC",
                     "description": "Specify the IANA time zone to use or 'local' to use the system time zone",
                     "type": "string"
-                },
-                "ui": {
-                    "additionalProperties": false,
-                    "properties": {
-                        "cursor-navigation": {
-                            "default": false,
-                            "description": "Enable arrow-key cursor navigation and Enter selection in menus",
-                            "enum": [
-                                true,
-                                false
-                            ],
-                            "type": "boolean"
-                        }
-                    },
-                    "type": "object"
                 }
             }
         }
     },
     "required": [
         "ansible-navigator"
     ],
-    "title": "ansible-navigator settings v24",
+    "title": "ansible-navigator settings v25",
     "type": "object",
-    "version": "24"
+    "version": "25"
 }

src/ansible_navigator/data/settings-sample.template.yml

@@ -63,9 +63,6 @@ ansible-navigator:
     enable: True
     # {{ color.osc4 }}
     osc4: True
-  ui:
-    # {{ ui.cursor-navigation }}
-    cursor-navigation: False
   editor:
     # {{ editor.command }}
     command: vim_from_setting

src/ansible_navigator/data/settings-schema.partial.json

@@ -284,15 +284,6 @@
         "time-zone": {
           "type": "string"
         },
-        "ui": {
-          "additionalProperties": false,
-          "properties": {
-            "cursor-navigation": {
-              "type": "boolean"
-            }
-          },
-          "type": "object"
-        },
         "settings": {
           "additionalProperties": false,
           "properties": {

src/ansible_navigator/ui_framework/ui.py

@@ -201,9 +201,9 @@ def __init__(
         self._screen.timeout(refresh)
         self._screen.keypad(True)  # Enable keypad mode for proper key handling
         self._one_line_input = FormHandlerText(screen=self._screen, ui_config=self._ui_config)
-        # When cursor navigation is enabled, this tracks which visible row to highlight
+        # This tracks which visible row to highlight
         self._highlight_line_offset: int | None = None
-        # When cursor navigation is enabled, this tracks the cursor position in menus
+        # This tracks the cursor position in menus
         self._menu_cursor_pos: int = 0
 
     def clear(self) -> None:
@@ -484,9 +484,9 @@ def _display(
                 line_index = line_numbers[idx]
                 line_index_str = str(line_index).rjust(index_width)
                 prefix = f"{line_index_str}\u2502"
-                # Apply highlight decoration when enabled and this is the selected row
-                if (indent_heading and self._ui_config.cursor_navigation and
-                    self._highlight_line_offset is not None and idx == self._highlight_line_offset):
+                # Apply highlight decoration when this is the selected row
+                if (indent_heading and self._highlight_line_offset is not None and
+                    idx == self._highlight_line_offset):
                     # Rebuild the line with reverse-video decoration added
                     highlighted_parts = tuple(
                         CursesLinePart(
@@ -526,11 +526,9 @@ def _display(
                 char = self._screen.getch()
                 key = "KEY_F(5)" if char == -1 else curses.keyname(char).decode()
                 # Debug: log the raw char and converted key for troubleshooting
-                if self._ui_config.cursor_navigation:
-                    self._logger.debug("Raw char: %s, Converted key: '%s'", char, key)
+                self._logger.debug("Raw char: %s, Converted key: '%s'", char, key)
                 # Check for Enter key codes and return a special value for cursor navigation
-                if (self._ui_config.cursor_navigation and
-                    char in [10, 13]):  # Enter key codes: 10=LF, 13=CR
+                if char in [10, 13]:  # Enter key codes: 10=LF, 13=CR
                     self._logger.debug(
                         "Enter key detected! Raw char: %s, setting key to CURSOR_ENTER", char
                     )
@@ -948,7 +946,7 @@ def _show_menu(
 
             # Determine which row to highlight, if enabled
             self._highlight_line_offset = None
-            if self._ui_config.cursor_navigation and self._menu_indices:
+            if self._menu_indices:
                 self._menu_cursor_pos = max(0, min(self._menu_cursor_pos,
                                                    len(self._menu_indices) - 1))
                 selected_global_index = self._menu_indices[self._menu_cursor_pos]
@@ -968,13 +966,11 @@ def _show_menu(
             )
 
             # Debug: log what entry we received
-            if self._ui_config.cursor_navigation:
-                self._logger.debug("Received entry: '%s'", entry)
+            self._logger.debug("Received entry: '%s'", entry)
 
             # Handle arrow navigation for menus when enabled
             if entry in ["KEY_RESIZE", "KEY_DOWN", "KEY_UP", "KEY_NPAGE", "KEY_PPAGE", "^F", "^B"]:
-                if (entry in ["KEY_DOWN", "KEY_UP"] and self._ui_config.cursor_navigation and
-                    self._menu_indices):
+                if (entry in ["KEY_DOWN", "KEY_UP"] and self._menu_indices):
                     # Move the cursor position
                     if entry == "KEY_DOWN" and self._menu_cursor_pos < len(self._menu_indices) - 1:
                         self._menu_cursor_pos += 1
@@ -997,8 +993,7 @@ def _show_menu(
                 continue
 
             # Enter key should select the highlighted item when cursor nav is enabled
-            if (self._ui_config.cursor_navigation and
-                    (entry == "CURSOR_ENTER" or entry in ["^J", "^M", "KEY_ENTER", "KEY_RETURN"]) and
+            if ((entry == "CURSOR_ENTER" or entry in ["^J", "^M", "KEY_ENTER", "KEY_RETURN"]) and
                     self._menu_indices):
                 self._logger.debug("Enter key selection triggered! Entry: '%s', Selecting index %s",
                                   entry, self._menu_cursor_pos)

src/ansible_navigator/ui_framework/ui_config.py

@@ -7,29 +7,22 @@
 
 @dataclass
 class UIConfig:
-    """The UI configuration.
+    """Object to hold basic UI settings.
 
-    Args:
-        color: Enable the use of color for mode interactive and stdout
-        colors_initialized: Whether colors have been initialized
-        cursor_navigation: Enable arrow-key cursor navigation and Enter selection in menus
-        grammar_dir: The path to the grammar directory
-        osc4: Enable or disable terminal color changing support with OSC 4
-        terminal_colors_path: The path to the terminal colors file
-        theme_path: The path to the theme file
+    Used to determine properties about rendering things. An instance of this
+    class gets threaded throughout most of the UI system, so it can be used for
+    fairly global things, such as "should we render color, ever?"
     """
 
-    #: Enable the use of color for mode interactive and stdout
+    #: Indicates coloring is enabled or disabled
     color: bool
-    #: Whether colors have been initialized
+    #: Indicates if the curses colors have been initialized
     colors_initialized: bool
     #: The path to the grammar directory
     grammar_dir: Traversable
-    #: Enable or disable terminal color changing support with OSC 4
+    #: Indicates if terminal support for OSC4 is enabled
     osc4: bool
-    #: The path to the terminal colors file
+    #: The path to the 16 terminal color map
     terminal_colors_path: Traversable
     #: The path to the theme file
     theme_path: Traversable
-    #: Enable arrow-key cursor navigation and Enter selection in menus
-    cursor_navigation: bool = False

tests/fixtures/unit/configuration_subsystem/ansible-navigator.yml

@@ -34,8 +34,6 @@ ansible-navigator:
   color:
     enable: False
     osc4: False
-  ui:
-    cursor-navigation: true
   editor:
     command: vim_from_setting
     console: False

tests/unit/configuration_subsystem/data.py

@@ -75,7 +75,6 @@ def d2t(dictionary: dict[Any, Any]) -> tuple[Any, ...]:
         "ansible_runner_timeout": 300,
         "container_engine": "docker",
         "container_options": ["--net=host"],
-        "cursor_navigation": True,
         "display_color": False,
         "editor_command": "vim_base",
         "editor_console": True,
@@ -237,7 +236,6 @@ def cli_data() -> Generator[ParameterSet, None, None]:
     pytest.param("config", "/tmp/ansible.cfg", "/tmp/ansible.cfg", id="7"),
     pytest.param("container_engine", "docker", "docker", id="8"),
     pytest.param("container_options", "--net=host", ["--net=host"], id="9"),
-    pytest.param("cursor_navigation", "true", True, id="9a"),
     pytest.param("display_color", "yellow is the color of a banana", False, id="10"),
     pytest.param("editor_command", "nano_env_var", "nano_env_var", id="11"),
     pytest.param("editor_console", "false", False, id="12"),