From 3eda29af7db309643f757d85b3e3a9bd3546af15 Mon Sep 17 00:00:00 2001 From: Sorin Sbarnea Date: Mon, 14 Apr 2025 14:46:43 +0100 Subject: [PATCH] Make navigator image pulling silent Because podman in particular is overly verbose even when image is already present, we switch to a default quiet mode. --- src/ansible_navigator/image_manager/puller.py | 2 +- tests/unit/image_manager/test_image_puller.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ansible_navigator/image_manager/puller.py b/src/ansible_navigator/image_manager/puller.py index 370234e94..18d860977 100644 --- a/src/ansible_navigator/image_manager/puller.py +++ b/src/ansible_navigator/image_manager/puller.py @@ -199,7 +199,7 @@ def _generate_pull_command(self) -> str: Returns: The command """ - command_line = [self._container_engine, "pull"] + command_line = [self._container_engine, "pull", "-q"] command_line.extend(self._arguments) command_line.append(self._image) joined_command = " ".join(command_line) diff --git a/tests/unit/image_manager/test_image_puller.py b/tests/unit/image_manager/test_image_puller.py index bf1f3a0f1..f31c54845 100644 --- a/tests/unit/image_manager/test_image_puller.py +++ b/tests/unit/image_manager/test_image_puller.py @@ -195,7 +195,7 @@ def test_pull_with_args() -> None: result = image_puller._generate_pull_command() expected_string = "podman pull --tls-verify false my_image" assert result == expected_string - expected_list = ["podman", "pull", "--tls-verify", "false", "my_image"] + expected_list = ["podman", "pull", "-q", "--tls-verify", "false", "my_image"] assert shlex.split(result) == expected_list