Skip to content

Commit 40e4434

Browse files
committed
Modify upon review
Signed-off-by: Alina Buzachis <[email protected]>
1 parent 70acf24 commit 40e4434

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

core/task_runner.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,5 +52,6 @@ def run_pattern_task(pattern_id: int, task_id: int) -> None:
5252
logger.error(f"Could not find pattern definition for task {task_id}")
5353
task.mark_failed({"error": "Pattern definition not found."})
5454
except Exception as e:
55-
logger.error(f"Task {task_id} failed: {e}")
56-
task.mark_failed({"error": str(e)})
55+
error_message = f"An unexpected error occurred {str(e)}."
56+
logger.exception(f"Task {task_id} failed unexpectedly.")
57+
task.mark_failed({"error": error_message})

core/utils/controller/helpers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def download_collection(collection_name: str, version: str) -> Iterator[str]:
3838
temporary directory.
3939
4040
Args:
41-
collection: The name of the collection (e.g., 'my_namespace.my_collection').
41+
collection_name: The name of the collection (e.g., 'my_namespace.my_collection').
4242
version: The version of the collection (e.g., '1.0.0').
4343
4444
Yields:

0 commit comments

Comments
 (0)