Update

Signed-off-by: Alina Buzachis <[email protected]>

Author: alinabuzachis

core/tasks.py

@@ -1,5 +1,3 @@
-from unittest.mock import patch
-
 from django.urls import reverse
 from rest_framework import status
 from rest_framework.test import APITestCase
@@ -9,7 +7,6 @@
 from core.models import Pattern
 from core.models import PatternInstance
 from core.models import Task
-from core.tasks import run_pattern_task
 
 
 class SharedDataMixin:
@@ -59,12 +56,7 @@ def test_pattern_detail_view(self):
         self.assertEqual(response.status_code, status.HTTP_200_OK)
         self.assertEqual(response.data["collection_name"], "mynamespace.mycollection")
 
-    @patch("core.views.async_to_sync")
-    def test_pattern_create_view(self, mock_async_to_sync):
-        """
-        Test POST /patterns/ creates Pattern and Task,
-        calls run_pattern_task and returns 202 with task_id.
-        """
+    def test_pattern_create_view(self):
         url = reverse("pattern-list")
         data = {
             "collection_name": "new.namespace.collection",
@@ -80,17 +72,15 @@ def test_pattern_create_view(self, mock_async_to_sync):
         pattern = Pattern.objects.get(pattern_name="new_pattern")
         self.assertIsNotNone(pattern)
 
-        # Task created pointing to pattern id
-        task_id = response.data["task_id"]
+        # Task id returned directly
+        task_id = response.data.get("task_id")
+        self.assertIsInstance(task_id, int)
+
+        # Task exists
         task = Task.objects.get(id=task_id)
         self.assertEqual(task.status, "Initiated")
-
-        mock_async_to_sync.assert_called_once()
-        args, kwargs = mock_async_to_sync.call_args
-        # The first argument should be run_pattern_task
-        self.assertEqual(args[0], run_pattern_task)
-        self.assertIn("task_id", response.data)
-        self.assertIn("message", response.data)
+        self.assertEqual(task.details.get("model"), "Pattern")
+        self.assertEqual(task.details.get("id"), pattern.id)
 
 
 class PatternInstanceViewSetTest(SharedDataMixin, APITestCase):
@@ -106,8 +96,7 @@ def test_pattern_instance_detail_view(self):
         self.assertEqual(response.status_code, status.HTTP_200_OK)
         self.assertEqual(response.data["organization_id"], 1)
 
-    @patch("core.views.async_to_sync")
-    def test_pattern_instance_create_view(self, mock_async_to_sync):
+    def test_pattern_instance_create_view(self):
         url = reverse("patterninstance-list")
         data = {
             "organization_id": 2,
@@ -124,13 +113,13 @@ def test_pattern_instance_create_view(self, mock_async_to_sync):
         instance = PatternInstance.objects.get(organization_id=2)
         self.assertIsNotNone(instance)
 
-        task_id = response.data["task_id"]
+        task_id = response.data.get("task_id")
+        self.assertIsInstance(task_id, int)
+
         task = Task.objects.get(id=task_id)
         self.assertEqual(task.status, "Initiated")
-
-        mock_async_to_sync.assert_called_once()
-        self.assertIn("task_id", response.data)
-        self.assertIn("message", response.data)
+        self.assertEqual(task.details.get("model"), "PatternInstance")
+        self.assertEqual(task.details.get("id"), instance.id)
 
 
 class AutomationViewSetTest(SharedDataMixin, APITestCase):