test: adding test for vertex and tests based on spaceclaim tutorials #2157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2157 +/- ##
==========================================
+ Coverage 94.81% 94.85% +0.04%
==========================================
Files 141 141
Lines 10444 10444
==========================================
+ Hits 9902 9907 +5
+ Misses 542 537 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@syscordan - can we check why some of the tests are failing? |
…om/ansys/pyansys-geometry into test/syscordan_vertex_sc_tutorials
…om/ansys/pyansys-geometry into test/syscordan_vertex_sc_tutorials
Found the issue, locally I was using an outdated Python so it was not failing locally. Once I upgraded to python 3.13 the test failed for me due to the combined bodies being lost after doing a unite. Still looking into why another test fails only in 25.2
|
… faces based on version
…om/ansys/pyansys-geometry into test/syscordan_vertex_sc_tutorials
|
The 2 failing checks are not due to my changes @RobPasMue so it should be okay to merge now. |
Yes I'm aware of that no worries - good to merge on my side! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created test that is meant for checking the support of vertices. Another test is added based on the SpaceClaim tutorials.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder)