Do not download binary when it already exist

Author: MaxymVlasov

hooks/_common.sh

@@ -573,6 +573,10 @@ function common::populate_tool_cache {
   local -r cache_dir="$5"
   local -r cached_bin="$6"
 
+  if [[ -x $cached_bin ]]; then
+    return 0
+  fi
+
   local tmp_dir
   tmp_dir=$(mktemp -d "${cache_dir}.XXXXXXXXXX") || {
     common::colorify "red" "ERROR: Failed to create a temp directory for '$tool_name' version '$version'."
@@ -595,12 +599,6 @@ function common::populate_tool_cache {
     return 1
   fi
 
-  # Someone else may have already won the race - use their result.
-  if [[ -x $cached_bin ]]; then
-    rm -rf "$tmp_dir"
-    return 0
-  fi
-
   # Atomic `rename(2)`: both sides are plain files, so a concurrent
   # reader never sees a partial write.
   if ! mv "$tmp_dir/$(basename "$cached_bin")" "$cached_bin" 2> /dev/null; then