add new parameter - #122
Merged
Merged
Conversation
HavierD
marked this pull request as draft
May 8, 2025 03:24
There was a problem hiding this comment.
Pull Request Overview
This PR updates the API parameter handling by replacing the use of "Condition" with "Parameter" and introduces a new parameter "TYPE".
- Updated test cases in RestApiTest.java to use new parameter keys.
- Modified RestServices.java and RestApi.java to retrieve inputs using the new "Parameter" enum.
- Renamed the enum in DatasetDownloadEnums.java from Condition to Parameter and added the new TYPE parameter.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/src/test/java/au/org/aodn/ogcapi/server/processes/RestApiTest.java | Updated test inputs to reflect the new enum naming and added a new TYPE parameter. |
| server/src/main/java/au/org/aodn/ogcapi/server/processes/RestServices.java | Updated parameter retrieval to use the new "Parameter" enum and included the new TYPE parameter. |
| server/src/main/java/au/org/aodn/ogcapi/server/processes/RestApi.java | Changed input retrieval from "Condition" to "Parameter". |
| server/src/main/java/au/org/aodn/ogcapi/server/core/model/enumeration/DatasetDownloadEnums.java | Renamed "Condition" to "Parameter" and added the TYPE parameter under the updated enum. |
Comments suppressed due to low confidence (2)
server/src/test/java/au/org/aodn/ogcapi/server/processes/RestApiTest.java:47
- Consider adding assertions in the test to verify that the new TYPE parameter is correctly processed in the API response.
inputs.put(DatasetDownloadEnums.Parameter.TYPE.getValue(), DatasetDownloadEnums.Type.SUB_SETTING.getValue());
server/src/main/java/au/org/aodn/ogcapi/server/core/model/enumeration/DatasetDownloadEnums.java:11
- [nitpick] The renaming of the enum from 'Condition' to 'Parameter' is a significant change; please update any related documentation or code comments to ensure future clarity.
public enum Parameter {
HavierD
marked this pull request as ready for review
May 8, 2025 03:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.