Skip to content

Commit e8d9659

Browse files
sdks/python: make milvus as extra dependency
1 parent 2784cde commit e8d9659

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

sdks/python/setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,6 @@ def get_portability_package_data():
401401
'typing-extensions>=3.7.0',
402402
'zstandard>=0.18.0,<1',
403403
'pyyaml>=3.12,<7.0.0',
404-
'pymilvus>=2.5.10,<3.0.0',
405404
# Dynamic dependencies must be specified in a separate list, otherwise
406405
# Dependabot won't be able to parse the main list. Any dynamic
407406
# dependencies will not receive updates from Dependabot.
@@ -588,7 +587,8 @@ def get_portability_package_data():
588587
'transformers==4.25.1'
589588
],
590589
'xgboost': ['xgboost>=1.6.0,<2.1.3', 'datatable==1.0.0'],
591-
'tensorflow-hub': ['tensorflow-hub>=0.14.0,<0.16.0']
590+
'tensorflow-hub': ['tensorflow-hub>=0.14.0,<0.16.0'],
591+
'milvus': ['pymilvus>=2.5.10,<3.0.0']
592592
},
593593
zip_safe=False,
594594
# PyPI package information.

sdks/python/tox.ini

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -562,3 +562,10 @@ commands =
562562
/bin/sh -c "pip freeze | grep -E tensorflow"
563563
# Allow exit code 5 (no tests run) so that we can run this command safely on arbitrary subdirectories.
564564
bash {toxinidir}/scripts/run_pytest.sh {envname} 'apache_beam/ml/transforms/embeddings'
565+
566+
[testenv:py{39,310,311,312,313}-milvus]
567+
extras = test,gcp,milvus
568+
commands =
569+
# Log versions for debugging.
570+
/bin/sh -c "pip freeze | grep -E 'pymilvus|testcontainers'"
571+
bash {toxinidir}/scripts/run_pytest.sh {envname} "{posargs}"

0 commit comments

Comments
 (0)