Skip to content

Commit 7846614

Browse files
committed
Enable range reads for MultiNodeTableWalkWithMutationTrackingTest and document failure modes for known problematic seeds
patch by Caleb Rackliffe; reviewed by Blake Eggleston for CASSANDRA-20898
1 parent 1bf0397 commit 7846614

File tree

2 files changed

+174
-221
lines changed

2 files changed

+174
-221
lines changed

test/distributed/org/apache/cassandra/distributed/test/cql3/MultiNodeTableWalkWithMutationTrackingTest.java

Lines changed: 22 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,29 @@ public MultiNodeTableWalkWithMutationTrackingTest()
5050
protected void preCheck(Cluster cluster, Property.StatefulBuilder builder)
5151
{
5252
// The following seeds fail with full coverage, including table scans, token restrictions, and range queries.
53+
54+
// Unexpected results for query: SELECT * FROM ks1.tbl WHERE v1 = ({f0: false, f1: 0x375365d533e5ff, f2: -5629}, [00000000-0000-1200-9b00-000000000000]) LIMIT 991 ALLOW FILTERING
55+
// No rows returned, 105 steps
5356
// builder.withSeed(3448511221048049990L).withExamples(1);
57+
58+
// SELECT * FROM ks1.tbl WHERE v4 > {-4237118076428244729, -1815831816430314156} ALLOW FILTERING -- v4 frozen<set<bigint>>, on node2, fetch size 5000
59+
// Timeout!, 22 steps
5460
// builder.withSeed(3448511767874561358L).withExamples(1);
61+
62+
// Unexpected results for query: SELECT * FROM ks1.tbl WHERE v3 > '브ﭶ熒讘ꯄ謏??䎸锭商Ử豫羀펛葕䝆㛔' LIMIT 785 ALLOW FILTERING
63+
// No rows returned, 52 steps
5564
// builder.withSeed(3448512096918920638L).withExamples(1);
65+
66+
// Unexpected results for query: SELECT * FROM ks1.tbl WHERE pk0 <= -14 LIMIT 659 ALLOW FILTERING
67+
// No rows returned, 117 steps
5668
// builder.withSeed(3448512193316910104L).withExamples(1);
69+
70+
// Unexpected results for query: SELECT * FROM ks1.tbl WHERE v0 >= [{0}, {0, 514}, {-1715, 3, 1215135}] PER PARTITION LIMIT 140 LIMIT 10 ALLOW FILTERING
71+
// Missing rows, likely related to CASSANDRA-20954
5772
// builder.withSeed(3448512636059630802L).withExamples(1);
58-
// builder.withSeed(3448508380521303242L).withExamples(1);
59-
// builder.withSeed(3448510029028090569L).withExamples(1);
73+
74+
// Unexpected results for query: SELECT * FROM ks1.tbl WHERE s0 > [[00000000-0000-1700-a700-000000000000, 00000000-0000-1a00-9100-000000000000, 00000000-0000-1500-a800-000000000000]] PER PARTITION LIMIT 184 LIMIT 491 ALLOW FILTERING
75+
// No rows returned, likely related to CASSANDRA-20954
6076
// builder.withSeed(3448154736661599106L).withExamples(1);
6177

6278
// CQL operations may have opertors such as +, -, and / (example 4 + 4), to "apply" them to get a constant value
@@ -87,15 +103,14 @@ public void test() throws IOException
87103
preCheck(cluster, statefulBuilder);
88104
statefulBuilder.check(commands(() -> rs -> createState(rs, cluster))
89105
.add(StatefulASTBase::insert)
90-
//.add(StatefulASTBase::fullTableScan)
106+
.add(StatefulASTBase::fullTableScan)
91107
.addIf(State::allowUsingTimestamp, StatefulASTBase::validateUsingTimestamp)
92108
.addIf(State::hasPartitions, this::selectExisting)
93-
//.addAllIf(State::supportTokens, this::selectToken, this::selectTokenRange, StatefulASTBase::selectMinTokenRange)
109+
.addAllIf(State::supportTokens, this::selectToken, this::selectTokenRange, StatefulASTBase::selectMinTokenRange)
94110
.addIf(State::hasEnoughMemtable, StatefulASTBase::flushTable)
95111
.addIf(State::hasEnoughSSTables, StatefulASTBase::compactTable)
96-
//.addAllIf(BaseState::allowRepair, StatefulASTBase::incrementalRepair, StatefulASTBase::previewRepair)
97-
//.addIf(State::allowNonPartitionQuery, this::nonPartitionQuery)
98-
//.addIf(State::allowNonPartitionMultiColumnQuery, this::multiColumnQuery)
112+
.addIf(State::allowNonPartitionQuery, this::nonPartitionQuery)
113+
.addIf(State::allowNonPartitionMultiColumnQuery, this::multiColumnQuery)
99114
.addIf(State::allowPartitionQuery, this::partitionRestrictedQuery)
100115
.destroyState(State::close)
101116
.commandsTransformer(LoggingCommand.factory())

0 commit comments

Comments
 (0)