Skip to content

Commit 270acdf

Browse files
committed
Fix gprecoverseg that contains bad backport code
The option differentialResynchronization is not defined in the options, which will cause gprecoverseg fails. if self.__options.differentialResynchronization: self.logger.error("gprecoverseg differential recovery failed. Please check the gpsegrecovery.py log" " file and rsync log file for more details.") else: self.logger.error("gprecoverseg failed. Please check the output for more details.") Because the code block is miss backported from GPDB upstream. The code was added in commit 07c4d13 The upstream greenplum-db/gpdb-archive@b84f08e2e1a299ded905921 introduced this option
1 parent 721a60d commit 270acdf

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

gpMgmt/bin/gppylib/programs/clsRecoverSegment.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -378,11 +378,6 @@ def signal_handler(sig, frame):
378378
if not mirrorBuilder.recover_mirrors(gpEnv, gpArray):
379379
if self.termination_requested:
380380
self.logger.error("gprecoverseg process was interrupted by the user.")
381-
if self.__options.differentialResynchronization:
382-
self.logger.error("gprecoverseg differential recovery failed. Please check the gpsegrecovery.py log"
383-
" file and rsync log file for more details.")
384-
else:
385-
self.logger.error("gprecoverseg failed. Please check the output for more details.")
386381
sys.exit(1)
387382

388383
if self.termination_requested:

0 commit comments

Comments
 (0)