SGA-11414 Added fixes from code review

Author: etgarperets

src/ast/mod.rs

@@ -7454,12 +7454,15 @@ impl fmt::Display for TypedString {
                 write!(f, "{data_type}")?;
                 write!(f, " {value}")
             }
-            true => match data_type {
-                DataType::Date => write!(f, "{{d {value}}}"),
-                DataType::Time(..) => write!(f, "{{t {value}}}"),
-                DataType::Timestamp(..) => write!(f, "{{ts {value}}}"),
-                _ => write!(f, "{{? {value}}}"),
-            },
+            true => {
+                let prefix = match data_type {
+                    DataType::Date => "d",
+                    DataType::Time(..) => "t",
+                    DataType::Timestamp(..) => "ts",
+                    _ => "?",
+                };
+                write!(f, "{{{prefix} {value}}}")
+            }
         }
     }
 }

src/parser/mod.rs

@@ -2030,8 +2030,12 @@ impl<'a> Parser<'a> {
         })
     }
 
-    // Tries to parse the body of an [ODBC escaping sequence]
+    /// Tries to parse the body of an [ODBC escaping sequence]
     /// i.e. without the enclosing braces
+    /// Currently implemented:
+    /// Scalar Function Calls
+    /// Date, Time, and Timestamp Literals
+    /// See https://learn.microsoft.com/en-us/sql/odbc/reference/develop-app/escape-sequences-in-odbc?view=sql-server-2017
     fn maybe_parse_odbc_body(&mut self) -> Result<Option<Expr>, ParserError> {
         // Attempt 1: Try to parse it as a function.
         if let Some(expr) = self.maybe_parse_odbc_fn_body()? {

tests/sqlparser_common.rs

@@ -16324,6 +16324,13 @@ fn test_odbc_time_date_timestamp_support() {
     let _ = all_dialects().verified_stmt(sql_ts);
 }
 
+#[test]
+#[should_panic]
+fn test_invalid_odbc_literal_fails() {
+    let sql = "SELECT {tt '14:12:01'} FROM foo";
+    let _ = all_dialects().verified_stmt(sql);
+}
+
 #[test]
 fn parse_create_user() {
     let create = verified_stmt("CREATE USER u1");