Skip to content

Conversation

@zhangstar333
Copy link
Contributor

Problem Summary:

  • In MySQL, LOG(col, e) is equivalent to LN(col), where e is Euler’s number (~2.71828).
  • Currently, MySQL also supports LOG(col) as a shorthand for LOG(col, e) (i.e., natural logarithm).
  • This conversion replaces LOG(col) with LN(col) when only a single argument is provided.

doc: apache/doris-website#2605

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Problem Summary:

* In MySQL, LOG(col, e) is equivalent to LN(col), where e is Euler’s
number (~2.71828).
* Currently, MySQL also supports LOG(col) as a shorthand for LOG(col, e)
(i.e., natural logarithm).
* This conversion replaces LOG(col) with LN(col) when only a single
argument is provided.

 doc: apache/doris-website#2605
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39821 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f690bfd20744f38c91a5edf5ba4af6a590b90a0a, data reload: false

------ Round 1 ----------------------------------
q1	17629	6851	6570	6570
q2	2065	200	174	174
q3	10639	1132	1097	1097
q4	10453	782	675	675
q5	7744	2847	2773	2773
q6	213	130	131	130
q7	958	634	614	614
q8	9368	1964	2087	1964
q9	6680	6356	6384	6356
q10	7062	2274	2236	2236
q11	463	282	268	268
q12	406	219	210	210
q13	17787	2972	3008	2972
q14	240	205	212	205
q15	512	464	465	464
q16	479	393	386	386
q17	984	589	560	560
q18	7315	6775	6830	6775
q19	1395	1098	1066	1066
q20	480	201	209	201
q21	4113	3149	3245	3149
q22	1064	998	976	976
Total cold run time: 108049 ms
Total hot run time: 39821 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6621	6559	6534	6534
q2	323	224	233	224
q3	2916	2977	2933	2933
q4	2081	1949	1885	1885
q5	5735	5725	5720	5720
q6	208	128	125	125
q7	2244	1841	1853	1841
q8	3369	3538	3572	3538
q9	8878	8886	8857	8857
q10	3569	3537	3520	3520
q11	594	494	503	494
q12	816	609	575	575
q13	8550	3255	3156	3156
q14	314	274	276	274
q15	514	461	464	461
q16	494	437	448	437
q17	1821	1621	1599	1599
q18	8310	7774	7869	7774
q19	1669	1578	1596	1578
q20	2054	1828	1818	1818
q21	5250	5075	5081	5075
q22	1111	1085	1011	1011
Total cold run time: 67441 ms
Total hot run time: 59429 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195521 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f690bfd20744f38c91a5edf5ba4af6a590b90a0a, data reload: false

query1	1291	919	915	915
query2	6358	1905	1861	1861
query3	10827	4343	4488	4343
query4	33301	23438	23620	23438
query5	3394	469	436	436
query6	270	187	191	187
query7	4011	318	326	318
query8	295	226	216	216
query9	9444	2550	2555	2550
query10	473	259	246	246
query11	18021	15264	15233	15233
query12	147	105	100	100
query13	1558	432	425	425
query14	8579	6505	7115	6505
query15	235	182	186	182
query16	7903	475	457	457
query17	1573	570	612	570
query18	2078	330	331	330
query19	247	178	173	173
query20	127	118	122	118
query21	211	111	111	111
query22	4667	4365	4406	4365
query23	34883	34599	33802	33802
query24	11602	2884	2856	2856
query25	659	452	424	424
query26	1238	182	175	175
query27	2771	366	355	355
query28	7651	2140	2147	2140
query29	912	477	459	459
query30	263	163	162	162
query31	1047	810	839	810
query32	101	58	58	58
query33	780	321	315	315
query34	941	540	513	513
query35	882	740	753	740
query36	1108	929	957	929
query37	137	75	67	67
query38	4115	3964	4003	3964
query39	1521	1458	1500	1458
query40	203	95	99	95
query41	51	45	48	45
query42	110	99	97	97
query43	509	466	482	466
query44	1354	840	809	809
query45	187	175	170	170
query46	1189	724	741	724
query47	2047	1878	1938	1878
query48	464	382	379	379
query49	1027	389	403	389
query50	839	430	438	430
query51	7489	7211	7322	7211
query52	102	100	93	93
query53	262	184	189	184
query54	1148	481	479	479
query55	79	75	79	75
query56	265	254	257	254
query57	1353	1214	1200	1200
query58	228	208	218	208
query59	3262	2965	2947	2947
query60	281	266	277	266
query61	110	108	108	108
query62	862	698	681	681
query63	229	194	192	192
query64	4173	674	651	651
query65	3325	3321	3320	3320
query66	796	305	300	300
query67	15999	15398	15478	15398
query68	4287	597	564	564
query69	430	263	266	263
query70	1153	1098	1079	1079
query71	342	250	247	247
query72	6343	4019	4044	4019
query73	763	338	341	338
query74	10560	8783	8982	8783
query75	3405	2623	2682	2623
query76	2715	1092	1099	1092
query77	399	265	266	265
query78	10592	9517	9621	9517
query79	1610	588	611	588
query80	1212	427	432	427
query81	537	219	219	219
query82	952	90	88	88
query83	230	152	146	146
query84	223	77	111	77
query85	1304	299	282	282
query86	394	294	296	294
query87	4389	4246	4275	4246
query88	3551	2354	2352	2352
query89	414	287	281	281
query90	1837	186	181	181
query91	178	147	149	147
query92	64	51	51	51
query93	1942	558	555	555
query94	790	302	294	294
query95	363	270	252	252
query96	616	287	289	287
query97	3295	3131	3181	3131
query98	217	201	198	198
query99	1553	1283	1280	1280
Total cold run time: 300224 ms
Total hot run time: 195521 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.11 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f690bfd20744f38c91a5edf5ba4af6a590b90a0a, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.06	0.06
query4	1.59	0.10	0.11
query5	0.53	0.52	0.50
query6	1.13	0.73	0.72
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.50	0.51
query10	0.56	0.55	0.57
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.61	0.60
query14	0.80	0.82	0.81
query15	0.84	0.83	0.82
query16	0.37	0.37	0.39
query17	0.98	1.07	1.04
query18	0.24	0.22	0.22
query19	1.91	1.80	1.86
query20	0.01	0.01	0.01
query21	15.40	0.59	0.59
query22	2.62	2.67	2.03
query23	16.68	1.06	0.82
query24	3.30	1.57	2.19
query25	0.26	0.14	0.22
query26	0.43	0.14	0.13
query27	0.05	0.04	0.06
query28	8.84	0.53	0.52
query29	12.58	3.23	3.22
query30	0.25	0.06	0.05
query31	2.86	0.40	0.38
query32	3.22	0.46	0.46
query33	2.98	3.02	2.99
query34	16.83	4.48	4.50
query35	4.53	4.54	4.48
query36	0.67	0.49	0.49
query37	0.09	0.06	0.06
query38	0.04	0.04	0.04
query39	0.04	0.02	0.02
query40	0.16	0.12	0.12
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 102.8 s
Total hot run time: 31.11 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants