DRILL-7759: Code compilation exception for queries containing (untyped) NULL

Author: KazydubB

exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java

@@ -1039,7 +1039,12 @@ private HoldingContainer visitBooleanAnd(BooleanOperator op,
 
         JBlock earlyExit = null;
         if (arg.isOptional()) {
-          earlyExit = eval._if(arg.getIsSet().eq(JExpr.lit(1)).cand(arg.getValue().ne(JExpr.lit(1))))._then();
+          JExpression expr1 = arg.getIsSet().eq(JExpr.lit(1));
+          // UntypedNullHolder does not have `value` field
+          if (arg.getMinorType() != TypeProtos.MinorType.NULL) {
+            expr1 = expr1.cand(arg.getValue().ne(JExpr.lit(1)));
+          }
+          earlyExit = eval._if(expr1)._then();
           if (e == null) {
             e = arg.getIsSet();
           } else {

exec/java-exec/src/test/java/org/apache/drill/TestUntypedNull.java

@@ -240,5 +240,14 @@ public void testCoalesceOnNotExistentColumnsInUDF2() throws Exception {
         .baselineValuesForSingleColumn(null, null, null, null, null)
         .go();
   }
+
+  @Test
+  public void testValueIsNotReferencedOnUntypedNullHolderInstance() throws Exception {
+    testBuilder()
+        .physicalPlanFromFile("physical_untyped_null.json")
+        .unOrdered()
+        .expectsEmptyResultSet()
+        .go();
+  }
 }
 

exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetComplex.java

@@ -197,6 +197,7 @@ public void notxistsField() throws Exception {
         .run();
   }
 
+  @Test
   public void testReadRepeatedDecimals() throws Exception {
 
     JsonStringArrayList<BigDecimal> ints = new JsonStringArrayList<>();

exec/java-exec/src/test/resources/physical_untyped_null.json

@@ -0,0 +1,56 @@
+{
+  "head" : {
+    "version" : 1,
+    "generator" : {
+      "type" : "ExplainHandler",
+      "info" : ""
+    },
+    "type" : "APACHE_DRILL_PHYSICAL",
+    "options" : [ ],
+    "queue" : 0,
+    "hasResourcePlan" : false,
+    "resultMode" : "EXEC"
+  },
+  "graph" : [ {
+    "pop" : "mock-scan",
+    "@id" : 5,
+    "url": "http://apache.org",
+    "entries":[
+      {"records": 100, "types": [
+        {"name": "order_date", "type": "DATE", "mode": "OPTIONAL"},
+        {"name": "order_type", "type": "VARCHAR", "mode": "REQUIRED"}
+      ]}
+    ]
+  }, {
+    "pop" : "filter",
+    "@id" : 4,
+    "child" : 5,
+    "expr" : "booleanAnd(booleanOr(booleanAnd(istrue(less_than_or_equal_to(`order_date`, cast( 1517443200000 as DATE)) ) , NULL) , isnottrue(less_than_or_equal_to(`order_date`, cast( 1517443200000 as DATE)) ) ) , booleanOr(istrue(booleanOr(equal(`order_date`, cast( 1588291200000 as DATE)) , equal(`order_date`, cast( 1575158400000 as DATE)) ) ) , booleanAnd(NULL, isnottrue(booleanOr(equal(`order_date`, cast( 1588291200000 as DATE)) , equal(`order_date`, cast( 1575158400000 as DATE)) ) ) ) ) ) "
+  }, {
+    "pop" : "selection-vector-remover",
+    "@id" : 3,
+    "child" : 4
+  }, {
+    "pop" : "project",
+    "@id" : 2,
+    "exprs" : [ {
+      "ref" : "`type`",
+      "expr" : "`order_type`"
+    } ],
+    "child" : 3,
+    "outputProj" : false
+  }, {
+    "pop" : "project",
+    "@id" : 1,
+    "exprs" : [ {
+      "ref" : "`type`",
+      "expr" : "`type`"
+    } ],
+    "child" : 2,
+    "outputProj" : true
+  }, {
+    "pop" : "screen",
+    "@id" : 0,
+    "child" : 1
+  } ]
+}