Skip to content

Commit e1fbd0a

Browse files
stotycnauroth
authored andcommitted
MAPREDUCE-7502. TestPipeApplication silently hangs
Closes #7902 Signed-off-by: Shilun Fan <[email protected]> Signed-off-by: Chris Nauroth <[email protected]> (cherry picked from commit 631939f)
1 parent e4532f2 commit e1fbd0a

File tree

3 files changed

+6
-3
lines changed
  • hadoop-mapreduce-project/hadoop-mapreduce-client

3 files changed

+6
-3
lines changed

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Application.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,8 @@ class Application<K1 extends WritableComparable, V1 extends Writable,
110110
String localPasswordFile = new File(".") + Path.SEPARATOR
111111
+ "jobTokenPassword";
112112
writePasswordToLocalFile(localPasswordFile, password, conf);
113-
env.put("hadoop.pipes.shared.secret.location", localPasswordFile);
113+
// FIXME This doesn't seem to be read anywhere
114+
env.put("hadoop_pipes_shared_secret_location", localPasswordFile);
114115

115116
List<String> cmd = new ArrayList<String>();
116117
String interpretor = conf.get(Submitter.INTERPRETOR);

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Submitter.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,9 @@ public class Submitter extends Configured implements Tool {
8282
public static final String IS_JAVA_REDUCE = "mapreduce.pipes.isjavareducer";
8383
public static final String PARTITIONER = "mapreduce.pipes.partitioner";
8484
public static final String INPUT_FORMAT = "mapreduce.pipes.inputformat";
85-
public static final String PORT = "mapreduce.pipes.command.port";
85+
// This is used as an environment variable, which doesn't allow dots.
86+
// FIXME This also seems to be used only for tests
87+
public static final String PORT = "mapreduce_pipes_command_port";
8688

8789
public Submitter() {
8890
this(new Configuration());

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/pipes/CommonStub.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ protected void writeObject(Writable obj, DataOutputStream stream)
9999
}
100100

101101
protected void initSoket() throws Exception {
102-
int port = Integer.parseInt(System.getenv("mapreduce.pipes.command.port"));
102+
int port = Integer.parseInt(System.getenv(Submitter.PORT));
103103

104104
java.net.InetAddress address = java.net.InetAddress.getLocalHost();
105105

0 commit comments

Comments
 (0)