Skip to content

Commit 11a7d86

Browse files
smaheshwar-pltrSreesh Maheshwar
andauthored
Nit: Clean up comments in DataScan::_build_residual_evaluator (#2197)
<!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change Cleaning up comments in `DataScan::_build_residual_evaluator`, no code changes. # Are these changes tested? N/A # Are there any user-facing changes? No <!-- In the case of user-facing changes, please add the changelog label. --> Co-authored-by: Sreesh Maheshwar <[email protected]>
1 parent 6c6df96 commit 11a7d86

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

pyiceberg/table/__init__.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1841,13 +1841,11 @@ def _build_metrics_evaluator(self) -> Callable[[DataFile], bool]:
18411841
def _build_residual_evaluator(self, spec_id: int) -> Callable[[DataFile], ResidualEvaluator]:
18421842
spec = self.table_metadata.specs()[spec_id]
18431843

1844+
from pyiceberg.expressions.visitors import residual_evaluator_of
1845+
18441846
# The lambda created here is run in multiple threads.
18451847
# So we avoid creating _EvaluatorExpression methods bound to a single
18461848
# shared instance across multiple threads.
1847-
# return lambda data_file: (partition_schema, partition_expr, self.case_sensitive)(data_file.partition)
1848-
from pyiceberg.expressions.visitors import residual_evaluator_of
1849-
1850-
# assert self.row_filter == False
18511849
return lambda datafile: (
18521850
residual_evaluator_of(
18531851
spec=spec,

0 commit comments

Comments
 (0)