From 9f6a15163336b6d6d73cb1c5688a7865a24d9df7 Mon Sep 17 00:00:00 2001
From: e11it <im@e11it.ru>
Date: Thu, 31 Aug 2023 16:10:24 +0300
Subject: [PATCH] Fix ImpalaToPrometheusName: replace single quote to
 underscore

Some metrics name in Java 11 contains single quote(example: `CodeHeap 'profiled methods'`).
Single quote not allowed for prometheus metrics.
---
 be/src/util/metrics.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/be/src/util/metrics.cc b/be/src/util/metrics.cc
index b1c22085d4..13e836d828 100644
--- a/be/src/util/metrics.cc
+++ b/be/src/util/metrics.cc
@@ -324,7 +324,7 @@ string MetricGroup::ImpalaToPrometheusName(const string& impala_metric_name) {
   // Substitute characters as needed to match prometheus conventions. The string is
   // already the right size so we can do this in place.
   for (size_t i = 0; i < result.size(); ++i) {
-    if (result[i] == '.' || result[i] == '-') result[i] = '_';
+    if (result[i] == '.' || result[i] == '-' || result[i] == '\'') result[i] = '_';
   }
   if (result.compare(0, 7, "impala_") != 0) {
     result.insert(0, "impala_");