chore(golang): fix linting errors after upgrade

Author: Kostas Petrakis

backend/core/migration/linter/main.go

@@ -51,7 +51,7 @@ func firstLineFromFile(path string) string {
 	for scanner.Scan() {
 		return scanner.Text()
 	}
-	panic(fmt.Errorf("empty file: " + path))
+	panic(fmt.Errorf("empty file: %s", path))
 }
 
 const (

backend/helpers/srvhelper/scope_service_helper.go

@@ -268,39 +268,39 @@ func (scopeSrv *ScopeSrvHelper[C, S, SC]) getAffectedTables() ([]string, errors.
 	if err != nil {
 		return nil, err
 	}
-	if pluginModel, ok := meta.(plugin.PluginModel); !ok {
+	pluginModel, ok := meta.(plugin.PluginModel)
+	if !ok {
 		panic(errors.Default.New(fmt.Sprintf("plugin \"%s\" does not implement listing its tables", scopeSrv.pluginName)))
-	} else {
-		// Unfortunately, can't cache the tables because Python creates some tables on a per-demand basis, so such a cache would possibly get outdated.
-		// It's a rare scenario in practice, but might as well play it safe and sacrifice some performance here
-		var allTables []string
-		if allTables, err = scopeSrv.db.AllTables(); err != nil {
-			return nil, err
-		}
-		// collect raw tables
-		for _, table := range allTables {
-			if strings.HasPrefix(table, "_raw_"+scopeSrv.pluginName) {
-				tables = append(tables, table)
-			}
+	}
+	// Unfortunately, can't cache the tables because Python creates some tables on a per-demand basis, so such a cache would possibly get outdated.
+	// It's a rare scenario in practice, but might as well play it safe and sacrifice some performance here
+	var allTables []string
+	if allTables, err = scopeSrv.db.AllTables(); err != nil {
+		return nil, err
+	}
+	// collect raw tables
+	for _, table := range allTables {
+		if strings.HasPrefix(table, "_raw_"+scopeSrv.pluginName) {
+			tables = append(tables, table)
 		}
-		// collect tool tables
-		toolModels := pluginModel.GetTablesInfo()
-		for _, toolModel := range toolModels {
-			if !isScopeModel(toolModel) && hasField(toolModel, "RawDataParams") {
-				tables = append(tables, toolModel.TableName())
-			}
+	}
+	// collect tool tables
+	toolModels := pluginModel.GetTablesInfo()
+	for _, toolModel := range toolModels {
+		if !isScopeModel(toolModel) && hasField(toolModel, "RawDataParams") {
+			tables = append(tables, toolModel.TableName())
 		}
-		// collect domain tables
-		for _, domainModel := range domaininfo.GetDomainTablesInfo() {
-			// we only care about tables with RawOrigin
-			ok = hasField(domainModel, "RawDataParams")
-			if ok {
-				tables = append(tables, domainModel.TableName())
-			}
+	}
+	// collect domain tables
+	for _, domainModel := range domaininfo.GetDomainTablesInfo() {
+		// we only care about tables with RawOrigin
+		ok = hasField(domainModel, "RawDataParams")
+		if ok {
+			tables = append(tables, domainModel.TableName())
 		}
-		// additional tables
-		tables = append(tables, models.CollectorLatestState{}.TableName())
 	}
+	// additional tables
+	tables = append(tables, models.CollectorLatestState{}.TableName())
 	scopeSrv.log.Debug("Discovered %d tables used by plugin \"%s\": %v", len(tables), scopeSrv.pluginName, tables)
 	return tables, nil
 }

backend/impls/logruslog/init.go

@@ -70,11 +70,11 @@ func init() {
 	if basePath == "" {
 		basePath = "./logs"
 	}
-	if abs, err := filepath.Abs(basePath); err != nil {
+	abs, err := filepath.Abs(basePath)
+	if err != nil {
 		panic(err)
-	} else {
-		basePath = filepath.Join(abs, "devlake.log")
 	}
+	basePath = filepath.Join(abs, "devlake.log")
 	var err errors.Error
 	Global, err = NewDefaultLogger(inner)
 	if err != nil {

backend/impls/logruslog/logger.go

@@ -72,11 +72,11 @@ func (l *DefaultLogger) Info(format string, a ...interface{}) {
 }
 
 func (l *DefaultLogger) Warn(err error, format string, a ...interface{}) {
-	l.Log(log.LOG_WARN, formatMessage(err, format, a...))
+	l.Log(log.LOG_WARN, "%s", formatMessage(err, format, a...))
 }
 
 func (l *DefaultLogger) Error(err error, format string, a ...interface{}) {
-	l.Log(log.LOG_ERROR, formatMessage(err, format, a...))
+	l.Log(log.LOG_ERROR, "%s", formatMessage(err, format, a...))
 }
 
 func (l *DefaultLogger) SetStream(config *log.LoggerStreamConfig) {

backend/plugins/github_graphql/tasks/issue_extractor.go

@@ -143,7 +143,7 @@ func convertGithubIssue(milestoneMap map[int]int, issue *GraphqlQueryIssue, conn
 		GithubCreatedAt: issue.CreatedAt,
 		GithubUpdatedAt: issue.UpdatedAt,
 	}
-	if issue.AssigneeList.Assignees != nil && len(issue.AssigneeList.Assignees) > 0 {
+	if len(issue.AssigneeList.Assignees) > 0 {
 		githubIssue.AssigneeId = issue.AssigneeList.Assignees[0].Id
 		githubIssue.AssigneeName = issue.AssigneeList.Assignees[0].Login
 	}

backend/server/api/shared/api_output.go

@@ -124,7 +124,7 @@ func ApiOutputSuccess(c *gin.Context, body interface{}, status int) {
 func ApiOutputAbort(c *gin.Context, err error) {
 	if e, ok := err.(errors.Error); ok {
 		logruslog.Global.Error(err, "HTTP %d abort-error", e.GetType().GetHttpCode())
-		_ = c.AbortWithError(e.GetType().GetHttpCode(), fmt.Errorf(e.Messages().Format()))
+		_ = c.AbortWithError(e.GetType().GetHttpCode(), fmt.Errorf("%s", e.Messages().Format()))
 	} else {
 		logruslog.Global.Error(err, "HTTP %d abort-error (native)", http.StatusInternalServerError)
 		_ = c.AbortWithError(http.StatusInternalServerError, err)