Skip to content

Commit cb80851

Browse files
committed
fix the release verification instructions for Linux
verify-release.sh runs in a child process, so the "cd src" appended to it in 7163147 never reached the reviewer's shell and left them one level above the Dockerfile, breaking the docker build step. Move the step back into release-review.adoc and align the manual extract block with it.
1 parent 71c038c commit cb80851

2 files changed

Lines changed: 12 additions & 5 deletions

File tree

scripts/verify-release.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,4 +59,6 @@ mkdir -p src
5959
cd src
6060
unzip -q -o ../*source*.zip
6161

62-
cd src
62+
# Do not "cd" here to position the reviewer: this runs as "bash ./verify-release.sh", so a child
63+
# process, and the change would be lost. The step stays in release-review.adoc, typed by the reviewer.
64+
echo "Sources extracted to $(pwd)"

src/site/antora/modules/ROOT/pages/release-review.adoc

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,13 +141,18 @@ for sigFile in *.asc; do gpg --verify $sigFile ${sigFile%.asc}; done
141141
+
142142
[source,bash]
143143
----
144-
mkdir -p src
145-
cd src
146-
unzip -q -o ../*source*.zip
144+
unzip -q -o *source*.zip -d src
145+
----
146+
====
147147
148+
// Keep this step here: verify-release.sh runs in a child process, so it cannot cd for the reader,
149+
// and the next step needs the extracted root (the Dockerfile), not the src below it.
150+
. Switch to the extracted sources, which is the directory holding the `Dockerfile`:
151+
+
152+
[source,bash]
153+
----
148154
cd src
149155
----
150-
====
151156
152157
. Verify the build (install https://docs.docker.com/engine/install[docker], if you haven't already):
153158
+

0 commit comments

Comments
 (0)