test

test

test

fix test

fix

Author: zhengruifeng

python/pyspark/sql/connect/dataframe.py

@@ -1732,22 +1732,6 @@ def __getitem__(
                     )
                 )
             else:
-                # TODO: revisit classic Spark's Dataset.col
-                # if (sparkSession.sessionState.conf.supportQuotedRegexColumnName) {
-                #   colRegex(colName)
-                # } else {
-                #   ConnectColumn(addDataFrameIdToCol(resolve(colName)))
-                # }
-
-                # validate the column name
-                if not hasattr(self._session, "is_mock_session"):
-                    from pyspark.sql.connect.types import verify_col_name
-
-                    # Try best to verify the column name with cached schema
-                    # If fails, fall back to the server side validation
-                    if not verify_col_name(item, self._schema):
-                        self.select(item).isLocal()
-
                 return self._col(item)
         elif isinstance(item, Column):
             return self.filter(item)

python/pyspark/sql/tests/test_column.py

@@ -133,8 +133,8 @@ def test_access_column(self):
         self.assertTrue(isinstance(df["key"], Column))
         self.assertTrue(isinstance(df[0], Column))
         self.assertRaises(IndexError, lambda: df[2])
-        self.assertRaises(AnalysisException, lambda: df["bad_key"])
         self.assertRaises(TypeError, lambda: df[{}])
+        self.assertRaises(AnalysisException, lambda: df.select(df["bad_key"]).schema)
 
     def test_column_name_with_non_ascii(self):
         columnName = "数量"