make all datetime types consistent with JVM type classes

Author: dengziming

python/pyspark/sql/types.py

@@ -368,15 +368,17 @@ class BooleanType(AtomicType, metaclass=DataTypeSingleton):
 
     pass
 
+class DatetimeType(AtomicType):
+    """Super class of ass datetime data type."""
+    def needConversion(self) -> bool:
+        return True
+
 
-class DateType(AtomicType, metaclass=DataTypeSingleton):
+class DateType(DatetimeType, metaclass=DataTypeSingleton):
     """Date (datetime.date) data type."""
 
     EPOCH_ORDINAL = datetime.datetime(1970, 1, 1).toordinal()
 
-    def needConversion(self) -> bool:
-        return True
-
     def toInternal(self, d: datetime.date) -> int:
         if d is not None:
             return d.toordinal() - self.EPOCH_ORDINAL
@@ -386,15 +388,16 @@ def fromInternal(self, v: int) -> datetime.date:
             return datetime.date.fromordinal(v + self.EPOCH_ORDINAL)
 
 
-class TimeType(AtomicType):
+class AnyTimeType(DatetimeType):
+    """A TIME type of any valid precision."""
+    pass
+
+class TimeType(AnyTimeType):
     """Time (datetime.time) data type."""
 
     def __init__(self, precision: int = 6):
         self.precision = precision
 
-    def needConversion(self) -> bool:
-        return True
-
     def toInternal(self, t: datetime.time) -> int:
         if t is not None:
             return (
@@ -422,12 +425,9 @@ def __repr__(self) -> str:
         return "TimeType(%d)" % (self.precision)
 
 
-class TimestampType(AtomicType, metaclass=DataTypeSingleton):
+class TimestampType(DatetimeType, metaclass=DataTypeSingleton):
     """Timestamp (datetime.datetime) data type."""
 
-    def needConversion(self) -> bool:
-        return True
-
     def toInternal(self, dt: datetime.datetime) -> int:
         if dt is not None:
             seconds = (
@@ -441,12 +441,9 @@ def fromInternal(self, ts: int) -> datetime.datetime:
             return datetime.datetime.fromtimestamp(ts // 1000000).replace(microsecond=ts % 1000000)
 
 
-class TimestampNTZType(AtomicType, metaclass=DataTypeSingleton):
+class TimestampNTZType(DatetimeType, metaclass=DataTypeSingleton):
     """Timestamp (datetime.datetime) data type without timezone information."""
 
-    def needConversion(self) -> bool:
-        return True
-
     @classmethod
     def typeName(cls) -> str:
         return "timestamp_ntz"