Skip to content

Commit c80f57d

Browse files
committed
fix: Align tests
1 parent 98203d7 commit c80f57d

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

superset-frontend/cypress-base/cypress/e2e/explore/chart.test.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,9 @@ function verifyDashboardSearch() {
6868
function verifyDashboardLink() {
6969
interceptDashboardGet();
7070
openDashboardsAddedTo();
71-
cy.get('.ant-dropdown-menu-submenu-popup').trigger('mouseover');
71+
cy.get('.ant-dropdown-menu-submenu-popup').trigger('mouseover', {
72+
force: true,
73+
});
7274
cy.get('.ant-dropdown-menu-submenu-popup a')
7375
.first()
7476
.invoke('removeAttr', 'target')

superset-frontend/src/dashboard/components/PropertiesModal/PropertiesModal.test.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -438,10 +438,9 @@ describe('PropertiesModal', () => {
438438
const props = createProps();
439439
const propsWithDashboardInfo = { ...props, dashboardInfo };
440440

441-
const open = () => waitFor(() => userEvent.click(getSelect()));
442441
const getSelect = () =>
443442
screen.getByRole('combobox', { name: SupersetCore.t('Owners') });
444-
443+
const open = () => waitFor(() => userEvent.click(getSelect()));
445444
const getElementsByClassName = (className: string) =>
446445
document.querySelectorAll(className)! as NodeListOf<HTMLElement>;
447446

superset-frontend/src/features/reports/ReportModal/HeaderReportDropdown/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ export const useHeaderReportMenuItems = ({
139139
}),
140140
);
141141
}
142-
}, [dispatch, shouldFetch, user.userId, dashboardId, resourceId]);
142+
}, [dispatch, shouldFetch, user?.userId, dashboardId, resourceId]);
143143

144144
// Don't show anything if user can't add reports
145145
if (!canAddReports()) {

0 commit comments

Comments
 (0)