-
Notifications
You must be signed in to change notification settings - Fork 16.1k
fix(security-manager): switch from deprecated get_session to session attribute #35290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(security-manager): switch from deprecated get_session to session attribute #35290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset/security/manager.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
663fe60 to
f99efb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #35290 +/- ##
===========================================
+ Coverage 0 71.86% +71.86%
===========================================
Files 0 587 +587
Lines 0 43483 +43483
Branches 0 4701 +4701
===========================================
+ Hits 0 31248 +31248
- Misses 0 11006 +11006
- Partials 0 1229 +1229
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @mistercrunch, can we get this PR merged :D |
SUMMARY
Updates SupersetSecurityManager to use the modern session property instead of the deprecated get_session method when querying the database.
After Flask-AppBuilder version v5.x, the method to access the security manager’s database session has changed.
Before (v4.x):
After (v5.x):
Link: https://flask-appbuilder.readthedocs.io/en/latest/versionmigration.html