Skip to content

Commit 6c3e990

Browse files
committed
fix: only change the shuffle seed if provided in stream.shuffle
1 parent c02087f commit 6c3e990

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

edsnlp/core/stream.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -796,7 +796,6 @@ def shuffle(
796796
# same program twice, the shuffling should be the same in both cases.
797797
# This is not garanteed by just creating random.Random() which does not
798798
# account
799-
seed = seed if seed is not None else random.getrandbits(32)
800799
if shuffle_reader:
801800
if shuffle_reader not in self.reader.emitted_sentinels:
802801
raise ValueError(f"Cannot shuffle by {shuffle_reader}")
@@ -807,13 +806,14 @@ def shuffle(
807806
config=stream.config,
808807
)
809808
stream.reader.shuffle = shuffle_reader
810-
stream.reader.rng = random.Random(seed)
809+
if seed is not None:
810+
stream.reader.rng = random.Random(seed)
811811
if any(not op.elementwise for op in self.ops) or not shuffle_reader:
812812
stream = stream.map_batches(
813813
pipe=shuffle,
814814
batch_size=batch_size,
815815
batch_by=batch_by,
816-
kwargs={"rng": random.Random(seed)},
816+
kwargs={"rng": random.Random(seed)} if seed is not None else {},
817817
)
818818
stream.validate_ops(ops=stream.ops, update=False)
819819
return stream

0 commit comments

Comments
 (0)