Skip to content

Conversation

@Pijukatel
Copy link
Collaborator

@Pijukatel Pijukatel commented Jul 30, 2025

Description

  • Run unit tests in CI also on MacOS to prevent OS-specific incompatible changes, for example: Memory estimation problem on MacOS #1329
  • Add time tolerance for the test_emit_system_info_event to minimize flakiness of the test.

@github-actions github-actions bot added this to the 120th sprint - Tooling team milestone Jul 30, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Jul 30, 2025
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Aug 12, 2025
@Pijukatel
Copy link
Collaborator Author

MacOS executors sometimes start with CPU usage of 100 % even before starting the test.

@Pijukatel Pijukatel force-pushed the run-uts-on-macos branch 2 times, most recently from 1e1e4ce to 4dc65b9 Compare December 5, 2025 11:02
@Pijukatel
Copy link
Collaborator Author

Looks like the Spotlight service on the executor can randomly start and use all the CPU. We should probably just turn it off on the executor, this service is completely useless in our context.

@Pijukatel Pijukatel force-pushed the run-uts-on-macos branch 2 times, most recently from 2056d9e to f4a00c2 Compare December 5, 2025 12:50
@Pijukatel
Copy link
Collaborator Author

Executor related changes made test_timeout_in_handler test stable on MacOS, but test_emit_system_info_event i still very flaky

@Pijukatel Pijukatel added the adhoc Ad-hoc unplanned task added during the sprint. label Dec 8, 2025
@Pijukatel Pijukatel requested a review from vdusek December 8, 2025 06:49
@Pijukatel Pijukatel marked this pull request as ready for review December 8, 2025 06:49
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pijukatel Pijukatel merged commit 8972e27 into master Dec 8, 2025
29 of 30 checks passed
@Pijukatel Pijukatel deleted the run-uts-on-macos branch December 8, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants