Check issuer observed generation (#479)

arturdzm · web-flow · commit 43a3b912dedb · 2023-04-03T22:29:57.000-04:00
diff --git a/utils/reconciler.go b/utils/reconciler.go
@@ -436,7 +436,10 @@ func (r *ReconcilerBase) GenerateCMIssuer(namespace string, prefix string, CACom
 
 	for i := range issuer.Status.Conditions {
 		if issuer.Status.Conditions[i].Type == certmanagerv1.IssuerConditionReady && issuer.Status.Conditions[i].Status == certmanagermetav1.ConditionFalse {
-			return errors.New("Certificate is not ready")
+			return errors.New("Certificate Issuer is not ready")
+		}
+		if issuer.Status.Conditions[i].Type == certmanagerv1.IssuerConditionReady && issuer.Status.Conditions[i].ObservedGeneration != issuer.ObjectMeta.Generation {
+			return errors.New("Certificate Issuer is not ready")
 		}
 	}
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -436,7 +436,10 @@ func (r *ReconcilerBase) GenerateCMIssuer(namespace string, prefix string, CACom`
`436`	`436`
`437`	`437`	`for i := range issuer.Status.Conditions {`
`438`	`438`	`if issuer.Status.Conditions[i].Type == certmanagerv1.IssuerConditionReady && issuer.Status.Conditions[i].Status == certmanagermetav1.ConditionFalse {`
`439`		`- return errors.New("Certificate is not ready")`
	`439`	`+ return errors.New("Certificate Issuer is not ready")`
	`440`	`+ }`
	`441`	`+ if issuer.Status.Conditions[i].Type == certmanagerv1.IssuerConditionReady && issuer.Status.Conditions[i].ObservedGeneration != issuer.ObjectMeta.Generation {`
	`442`	`+ return errors.New("Certificate Issuer is not ready")`
`440`	`443`	`}`
`441`	`444`	`}`
`442`	`445`	`return nil`