Skip to content

Commit 87aac8c

Browse files
authored
Merge pull request #545 from application-stacks/monitor-https
prometheus insists scheme is 'https' not 'HTTPS'
2 parents d2b9268 + 13eda59 commit 87aac8c

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

bundle/tests/scorecard/kuttl/monitor/02-assert.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ spec:
2121
app.kubernetes.io/instance: service-monitor-rc
2222
endpoints:
2323
- path: "/path"
24-
scheme: "myScheme"
24+
scheme: "https"
2525
port: 3000-tcp
2626
params:
2727
params:

bundle/tests/scorecard/kuttl/monitor/02-runtime-update-monitor.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ spec:
66
monitoring:
77
endpoints:
88
- path: "/path"
9-
scheme: "myScheme"
9+
scheme: "https"
1010
params:
1111
params:
1212
- "param1"

utils/utils.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1040,7 +1040,7 @@ func CustomizeServiceMonitor(sm *prometheusv1.ServiceMonitor, ba common.BaseComp
10401040
}
10411041
if ba.GetManageTLS() == nil || *ba.GetManageTLS() {
10421042
if len(ba.GetMonitoring().GetEndpoints()) == 0 || ba.GetMonitoring().GetEndpoints()[0].TLSConfig == nil {
1043-
sm.Spec.Endpoints[0].Scheme = "HTTPS"
1043+
sm.Spec.Endpoints[0].Scheme = "https"
10441044
if sm.Spec.Endpoints[0].TLSConfig == nil {
10451045
sm.Spec.Endpoints[0].TLSConfig = &prometheusv1.TLSConfig{}
10461046
}

0 commit comments

Comments
 (0)