From 42a02913452bd96f47c8fc51f145e3f3bdfb85ee Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Wed, 23 Jul 2025 16:46:19 +0530 Subject: [PATCH 1/4] fix: Enable Update button for any field change in all OAuth provider modals --- .../auth/(providers)/appleOAuth.svelte | 5 ++--- .../auth/(providers)/auth0OAuth.svelte | 5 ++--- .../auth/(providers)/authentikOAuth.svelte | 5 ++--- .../auth/(providers)/gitlabOAuth.svelte | 5 ++--- .../auth/(providers)/googleOAuth.svelte | 8 +++----- .../auth/(providers)/mainOAuth.svelte | 8 +++----- .../auth/(providers)/microsoftOAuth.svelte | 10 ++++------ .../auth/(providers)/oidcOAuth.svelte | 5 ++--- .../auth/(providers)/oktaOAuth.svelte | 16 ++++++++++------ 9 files changed, 30 insertions(+), 37 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/appleOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/appleOAuth.svelte index f953c690e2..2d0bb767dc 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/appleOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/appleOAuth.svelte @@ -73,10 +73,9 @@ diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/auth0OAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/auth0OAuth.svelte index 510359bc32..364a8e1562 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/auth0OAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/auth0OAuth.svelte @@ -77,10 +77,9 @@ diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/authentikOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/authentikOAuth.svelte index 0c986847f5..3ce0bf9287 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/authentikOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/authentikOAuth.svelte @@ -81,10 +81,9 @@ diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/gitlabOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/gitlabOAuth.svelte index 5c54a19421..20a314618f 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/gitlabOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/gitlabOAuth.svelte @@ -76,10 +76,9 @@ diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/googleOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/googleOAuth.svelte index c56d54ff5a..380bd5f760 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/googleOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/googleOAuth.svelte @@ -72,11 +72,9 @@ diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/mainOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/mainOAuth.svelte index 85fcdb91d0..8fcf41ce4e 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/mainOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/mainOAuth.svelte @@ -71,11 +71,9 @@ diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/microsoftOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/microsoftOAuth.svelte index 253c7b4297..20dcd49c04 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/microsoftOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/microsoftOAuth.svelte @@ -42,9 +42,8 @@ clientSecret && tenantID ? JSON.stringify({ clientSecret, tenantID }) : provider.secret; - - {provider.name} OAuth2 settings -

+ +

To use {provider.name} authentication in your application, first fill in this form. For more info you can @@ -78,10 +77,9 @@ diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/oidcOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/oidcOAuth.svelte index 90a61e14f8..aca98bbf94 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/oidcOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/oidcOAuth.svelte @@ -115,10 +115,9 @@ diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/oktaOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/oktaOAuth.svelte index f1c7a30be1..06b23759c6 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/oktaOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/oktaOAuth.svelte @@ -47,9 +47,14 @@ : provider.secret; - - {provider.name} OAuth2 settings -

+ +

To use {provider.name} authentication in your application, first fill in this form. For more info you can From 907b101d58d2f3e9e6edb22ced527881a2bb94d9 Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Wed, 23 Jul 2025 17:53:27 +0530 Subject: [PATCH 2/4] fix:Require App ID and App Secret, update button logic for all --- .../auth/(providers)/appleOAuth.svelte | 19 +++++++++------ .../auth/(providers)/auth0OAuth.svelte | 24 ++++++++++++------- .../auth/(providers)/authentikOAuth.svelte | 18 +++++++++----- .../auth/(providers)/gitlabOAuth.svelte | 20 ++++++++-------- .../auth/(providers)/googleOAuth.svelte | 14 +++++++---- .../auth/(providers)/mainOAuth.svelte | 14 +++++++---- .../auth/(providers)/microsoftOAuth.svelte | 14 +++++++---- .../auth/(providers)/oidcOAuth.svelte | 18 +++++++++----- .../auth/(providers)/oktaOAuth.svelte | 22 +++++++++++------ 9 files changed, 103 insertions(+), 60 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/appleOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/appleOAuth.svelte index 2d0bb767dc..788922eb43 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/appleOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/appleOAuth.svelte @@ -60,10 +60,11 @@ label="Services ID" autofocus={true} placeholder="com.company.appname" - bind:value={appId} /> - - - + bind:value={appId} + required /> + + + To complete set up, add this OAuth2 redirect URI to your {provider.name} app configuration. @@ -73,9 +74,13 @@ diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/auth0OAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/auth0OAuth.svelte index 364a8e1562..aec1fa3271 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/auth0OAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/auth0OAuth.svelte @@ -52,22 +52,25 @@ + bind:value={appId} + required /> + bind:value={clientSecret} + required /> + placeholder="your-tenant.auth0.com" + bind:value={auth0Domain} + required /> To complete set up, add this OAuth2 redirect URI to your {provider.name} app configuration. @@ -77,9 +80,12 @@ diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/authentikOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/authentikOAuth.svelte index 3ce0bf9287..d367dbd773 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/authentikOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/authentikOAuth.svelte @@ -60,18 +60,21 @@ label="Client ID" autofocus={true} placeholder="Enter ID" - bind:value={appId} /> + bind:value={appId} + required /> + bind:value={clientSecret} + required /> + bind:value={authentikDomain} + required /> To complete set up, add this OAuth2 redirect URI to your {provider.name} app configuration. @@ -81,9 +84,12 @@ diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/gitlabOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/gitlabOAuth.svelte index 20a314618f..c434ebd5a2 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/gitlabOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/gitlabOAuth.svelte @@ -55,18 +55,16 @@ label="App ID" autofocus={true} placeholder="Enter ID" - bind:value={appId} /> + bind:value={appId} + required /> - + bind:value={clientSecret} + required /> + To complete set up, add this OAuth2 redirect URI to your {provider.name} app configuration. @@ -76,9 +74,11 @@ diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/googleOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/googleOAuth.svelte index 380bd5f760..cf01f41a93 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/googleOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/googleOAuth.svelte @@ -54,13 +54,15 @@ label="App ID" autofocus={true} placeholder="Enter ID" - bind:value={appId} /> + bind:value={appId} + required /> + bind:value={secret} + required /> To complete the setup, create an OAuth2 client ID with "Web application" as the application type, then add this redirect URI to your {provider.name} configuration. @@ -72,9 +74,11 @@ diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/mainOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/mainOAuth.svelte index 8fcf41ce4e..8e33f10229 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/mainOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/mainOAuth.svelte @@ -55,13 +55,15 @@ label="App ID" autofocus={true} placeholder="Enter ID" - bind:value={appId} /> + bind:value={appId} + required /> + bind:value={secret} + required /> To complete set up, add this OAuth2 redirect URI to your {provider.name} app configuration. @@ -71,9 +73,11 @@ diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/microsoftOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/microsoftOAuth.svelte index 20dcd49c04..782df6879a 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/microsoftOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/microsoftOAuth.svelte @@ -56,13 +56,15 @@ label="Application (client) ID" autofocus={true} placeholder="Enter ID" - bind:value={appId} /> + bind:value={appId} + required /> + bind:value={clientSecret} + required /> diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/oidcOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/oidcOAuth.svelte index aca98bbf94..bb88494114 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/oidcOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/oidcOAuth.svelte @@ -78,18 +78,21 @@ label="Client ID" autofocus={true} placeholder="Enter ID" - bind:value={appId} /> + bind:value={appId} + required /> + bind:value={clientSecret} + required /> + bind:value={wellKnownEndpoint} + required /> diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/oktaOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/oktaOAuth.svelte index 06b23759c6..65e832d3bb 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/oktaOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/oktaOAuth.svelte @@ -66,23 +66,27 @@ label="Client ID" autofocus={true} placeholder="Enter ID" - bind:value={appId} /> + bind:value={appId} + required /> + bind:value={clientSecret} + required /> + bind:value={oktaDomain} + required /> + bind:value={authorizationServerId} + required /> To complete set up, add this OAuth2 redirect URI to your {provider.name} app configuration. @@ -93,9 +97,13 @@ From 1bd6836b995c75f9e6c2ade0299c8ce773709561 Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Wed, 23 Jul 2025 17:56:42 +0530 Subject: [PATCH 3/4] fix:changed id back --- .../auth/(providers)/auth0OAuth.svelte | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/auth0OAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/auth0OAuth.svelte index aec1fa3271..5f97318c83 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/auth0OAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/auth0OAuth.svelte @@ -52,7 +52,7 @@ Date: Thu, 24 Jul 2025 17:08:28 +0530 Subject: [PATCH 4/4] fix: added chnages --- .../auth/(providers)/oidcOAuth.svelte | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/auth/(providers)/oidcOAuth.svelte b/src/routes/(console)/project-[region]-[project]/auth/(providers)/oidcOAuth.svelte index bb88494114..40637fb91c 100644 --- a/src/routes/(console)/project-[region]-[project]/auth/(providers)/oidcOAuth.svelte +++ b/src/routes/(console)/project-[region]-[project]/auth/(providers)/oidcOAuth.svelte @@ -92,22 +92,25 @@ label="Well-Known Endpoint" placeholder="https://example.com/.well-known/openid-configuration" bind:value={wellKnownEndpoint} - required /> + required={!authorizationEndpoint && !tokenEndpoint && !userinfoEndpoint} /> + bind:value={authorizationEndpoint} + required={!wellKnownEndpoint} /> + bind:value={tokenEndpoint} + required={!wellKnownEndpoint} /> + bind:value={userinfoEndpoint} + required={!wellKnownEndpoint} /> To complete set up, add this OAuth2 redirect URI to your {provider.name} app configuration. @@ -120,7 +123,8 @@