Add time between queries #85
Conversation
WalkthroughREADME SPM example now requires sdk-for-apple from 12.0.0. Client.default x-sdk-version header changed to 12.0.0. Query adds 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Sources/Appwrite/Services/Account.swift (1)
52-60: Fix typos in user-facing doc commentsMinor spelling fixes; these ship to developers in symbol docs.
-/// [/account/verfication](https://appwrite.io/docs/references/cloud/client-web/account#createVerification) +/// [/account/verification](https://appwrite.io/docs/references/cloud/client-web/account#createVerification) -/// List the factors available on the account to be used as a MFA challange. +/// List the factors available on the account to be used as an MFA challenge. -/// generate and show then immediately after user successfully adds their -/// authehticator. +/// generate and show them immediately after the user successfully adds their +/// authenticator. -/// An OTP challenge is required to regenreate recovery codes. +/// An OTP challenge is required to regenerate recovery codes.Also applies to: 102-110, 793-803, 943-951, 976-984
🧹 Nitpick comments (7)
README.md (1)
22-22: Prefer HTTPS package URL for SPM/Xcode UX.Xcode’s “Add Package” flow expects an HTTPS URL. Suggest switching from SSH to HTTPS in both places to reduce friction.
- In the dialog that appears, enter the Appwrite Swift SDK [package URL]([email protected]:appwrite/sdk-for-apple.git) in the search field. Once found, select `sdk-for-apple`. + In the dialog that appears, enter the Appwrite Swift SDK [package URL](https://github.com/appwrite/sdk-for-apple.git) in the search field. Once found, select `sdk-for-apple`.- .package(url: "[email protected]:appwrite/sdk-for-apple.git", from: "12.0.0"), + .package(url: "https://github.com/appwrite/sdk-for-apple.git", from: "12.0.0"),Also applies to: 34-35
Sources/Appwrite/Services/Account.swift (2)
1511-1578: Add renamed: to deprecation for fix-it guidanceXcode can auto-rename usages when you include
renamed:.-@available(*, deprecated, message: "This API has been deprecated since 1.6.0. Please use `Account.createSession` instead.") +@available(*, deprecated, renamed: "createSession", message: "Deprecated since 1.6.0. Use `Account.createSession`.") open func updateMagicURLSession(
1651-1678: Add renamed: to deprecation for fix-it guidanceMirror the same improvement here.
-@available(*, deprecated, message: "This API has been deprecated since 1.6.0. Please use `Account.createSession` instead.") +@available(*, deprecated, renamed: "createSession", message: "Deprecated since 1.6.0. Use `Account.createSession`.") open func updatePhoneSession(Sources/Appwrite/Query.swift (2)
72-96: Handle Float and avoid silent element drops in nested conversionCurrently,
Floatvalues are dropped and unknown items are silently skipped. AddFloatsupport and fail conversion when any element is unsupported to prevent partial data loss.Run tests that exercise nested coordinates containing
Floatvalues and mixed numeric types.private static func convertToQueryValueArray(_ values: Any?) -> [QueryValue]? { switch values { case let valueArray as [QueryValue]: return valueArray case let stringArray as [String]: return stringArray.map { .string($0) } case let intArray as [Int]: return intArray.map { .int($0) } case let doubleArray as [Double]: return doubleArray.map { .double($0) } + case let floatArray as [Float]: + return floatArray.map { .double(Double($0)) } case let boolArray as [Bool]: return boolArray.map { .bool($0) } case let queryArray as [Query]: return queryArray.map { .query($0) } case let stringValue as String: return [.string(stringValue)] case let intValue as Int: return [.int(intValue)] case let doubleValue as Double: return [.double(doubleValue)] + case let floatValue as Float: + return [.double(Double(floatValue))] case let boolValue as Bool: return [.bool(boolValue)] case let queryValue as Query: return [.query(queryValue)] case let anyArray as [Any]: - // Handle nested arrays - let nestedValues = anyArray.compactMap { item -> QueryValue? in - if let stringValue = item as? String { - return .string(stringValue) - } else if let intValue = item as? Int { - return .int(intValue) - } else if let doubleValue = item as? Double { - return .double(doubleValue) - } else if let boolValue = item as? Bool { - return .bool(boolValue) - } else if let queryValue = item as? Query { - return .query(queryValue) - } else if let nestedArray = item as? [Any] { - // Convert nested array to QueryValue.array - if let converted = convertToQueryValueArray(nestedArray) { - return .array(converted) - } - return nil - } - return nil - } - return nestedValues.isEmpty ? nil : nestedValues + // Handle nested arrays; fail the whole array if any element is unsupported + var nestedValues: [QueryValue] = [] + for item in anyArray { + if let stringValue = item as? String { + nestedValues.append(.string(stringValue)) + } else if let intValue = item as? Int { + nestedValues.append(.int(intValue)) + } else if let doubleValue = item as? Double { + nestedValues.append(.double(doubleValue)) + } else if let floatValue = item as? Float { + nestedValues.append(.double(Double(floatValue))) + } else if let boolValue = item as? Bool { + nestedValues.append(.bool(boolValue)) + } else if let queryValue = item as? Query { + nestedValues.append(.query(queryValue)) + } else if let nestedArray = item as? [Any], let converted = convertToQueryValueArray(nestedArray) { + nestedValues.append(.array(converted)) + } else { + return nil + } + } + return nestedValues default: return nil } }Also applies to: 96-119
447-541: Consider minimal docs for new spatial/distance buildersA short doc comment on expected
valuesshape (e.g., GeoJSON-like coordinates) andmeterssemantics will reduce misuse.Sources/Appwrite/Client.swift (1)
26-26: Version bump verified across codebase
No stale x-sdk-version entries found and README.md’s SPM snippet is updated to 12.0.0. Consider refactoringx-sdk-versionto use a single staticsdkVersionconstant in Client.swift for future bumps.Sources/AppwriteEnums/ExecutionMethod.swift (1)
10-10: Naming nit: consider lowerCamelCase in a future majorSwift case names are typically lowerCamelCase (e.g.,
head). KeepinghEADis fine for consistency today; consider a rename with deprecations in the next major.Optionally add a short doc comment now:
- case hEAD = "HEAD" + /// HTTP HEAD + case hEAD = "HEAD"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (9)
README.md(1 hunks)Sources/Appwrite/Client.swift(1 hunks)Sources/Appwrite/Query.swift(7 hunks)Sources/Appwrite/Services/Account.swift(2 hunks)Sources/AppwriteEnums/CreditCard.swift(1 hunks)Sources/AppwriteEnums/ExecutionMethod.swift(1 hunks)docs/examples/account/update-prefs.md(1 hunks)docs/examples/databases/create-document.md(1 hunks)docs/examples/tablesdb/create-row.md(1 hunks)
🔇 Additional comments (9)
README.md (1)
34-35: Confirm version bump and tag
README updated to 12.0.0; no lingering 11.0.0 references orx-sdk-versionheaders detected in Sources. Please manually verify the upstream12.0.0tag exists.docs/examples/account/update-prefs.md (1)
10-14: LGTM — clearer prefs payload.Concrete keys/values make the example more useful. No issues from my side.
Sources/AppwriteEnums/CreditCard.swift (1)
16-16: Add legacy decoding for “union-china-pay”
ImplementCodablewith a custominit(from:)that maps both"unionpay"and"union-china-pay"to.unionPay, and default encoding ofrawValue. Optionally add a deprecatedunionChinaPayalias for migration. A search (rg -n 'unionChinaPay|union-china-pay') returned no hits—manually verify no remaining legacy references.Sources/Appwrite/Query.swift (4)
9-10: Enum case for nested arrays looks goodNew
QueryValue.array([QueryValue])enables nested arrays without breaking ABI.
14-31: Decoder path LGTMOrder of decode attempts is fine; arrays fall through to
[QueryValue]safely.
47-49: Encoder path LGTMNested arrays are encoded correctly via single value container.
389-395: Range helpers are consistent and clear
createdBetween/updatedBetweenalign with existing before/after APIs.Also applies to: 410-415
Sources/AppwriteEnums/ExecutionMethod.swift (2)
10-10: HEAD support added correctlyThe new case maps to "HEAD" via rawValue and will serialize as expected. No behavioral concerns here.
10-10: Remove unused ExecutionMethod enum or integrate it for HEAD support
ExecutionMethod isn’t referenced in any switch or whitelist – HTTP calls pass raw strings. Either eliminate the dead enum or refactor Client.call to use ExecutionMethod (including .hEAD) if you intend to support HEAD.Likely an incorrect or invalid review comment.
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)
Summary by CodeRabbit
New Features
Breaking Changes
Documentation
Chores