Skip to content

Commit 84e2ae6

Browse files
authored
Update Selenium version to v4.34.0 +semver: feature (#271)
update extensions to use latest available devTools v137 stabilize ManyTools tests by removing cookie consent
1 parent b8fd334 commit 84e2ae6

File tree

6 files changed

+11
-17
lines changed

6 files changed

+11
-17
lines changed

Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@
9191
</ItemGroup>
9292

9393
<ItemGroup>
94-
<PackageReference Include="Aquality.Selenium.Core" Version="3.3.0" />
95-
<PackageReference Include="WebDriverManager" Version="2.17.5" />
94+
<PackageReference Include="Aquality.Selenium.Core" Version="3.4.0" />
95+
<PackageReference Include="WebDriverManager" Version="2.17.6" />
9696
</ItemGroup>
9797

9898
</Project>

Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.xml

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsEmulationExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
using Aquality.Selenium.Core.Utilities;
22
using OpenQA.Selenium.DevTools;
3-
using OpenQA.Selenium.DevTools.V137.DOM;
4-
using OpenQA.Selenium.DevTools.V137.Emulation;
3+
using OpenQA.Selenium.DevTools.V138.DOM;
4+
using OpenQA.Selenium.DevTools.V138.Emulation;
55
using System;
66
using System.Collections.Generic;
77
using System.Linq;

Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsPerformanceExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using OpenQA.Selenium.DevTools.V137.Performance;
1+
using OpenQA.Selenium.DevTools.V138.Performance;
22
using System.Collections.Generic;
33
using System.Globalization;
44
using System.Linq;

Aquality.Selenium/tests/Aquality.Selenium.Tests/Aquality.Selenium.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<PrivateAssets>all</PrivateAssets>
3535
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
3636
</PackageReference>
37-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.0" />
37+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
3838
</ItemGroup>
3939

4040
<ItemGroup>

Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/TestApp/ManyTools/Forms/ManyToolsForm.cs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ internal abstract class ManyToolsForm<T> : Form where T : ManyToolsForm<T>
1515
protected ManyToolsForm(By locator, string name) : base(locator, name)
1616
{
1717
}
18-
private IButton AgreeButton => ElementFactory.GetButton(By.XPath("//button[@mode='primary']"), "Agree");
18+
1919
private ILabel ValueLabel => FormElement.FindChildElement<ILabel>(By.XPath(".//code"), Name);
2020

2121
protected abstract string UrlPart { get; }
@@ -29,13 +29,7 @@ public T Open()
2929
AqualityServices.Get<IActionRetrier>().DoWithRetry(() =>
3030
{
3131
AqualityServices.Browser.GoTo(Url);
32-
AqualityServices.Browser.WaitForPageToLoad();
3332
State.WaitForDisplayed();
34-
if (AgreeButton.State.IsDisplayed)
35-
{
36-
AgreeButton.Click();
37-
AgreeButton.State.WaitForNotDisplayed();
38-
}
3933
}, new List<Type> { typeof(WebDriverTimeoutException) });
4034

4135
return (T)this;

0 commit comments

Comments
 (0)