Skip to content

Add method to change encoder encoding type. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2025
Merged

Add method to change encoder encoding type. #29

merged 2 commits into from
Jul 22, 2025

Conversation

jiander-snap
Copy link
Contributor

The MachineControl_Encoders class defaults to X2 encoding and provides no way to change to X1 or X4. This change implements the setEncoding() to support changing the encoding type.

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link

Memory usage change @ 21b2ff5

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
Click for full report table
Board examples/Analog_Out
flash		 % examples/Analog_Out
RAM for global variables		 % examples/Analog_input/Analog_input_0_10V
flash		 % examples/Analog_input/Analog_input_0_10V
RAM for global variables		 % examples/Analog_input/Analog_input_4_20mA
flash		 % examples/Analog_input/Analog_input_4_20mA
RAM for global variables		 % examples/Analog_input/Analog_input_NTC
flash		 % examples/Analog_input/Analog_input_NTC
RAM for global variables		 % examples/Analog_input/Fast_Analog_input_0_10V
flash		 % examples/Analog_input/Fast_Analog_input_0_10V
RAM for global variables		 % examples/CAN/ReadCan
flash		 % examples/CAN/ReadCan
RAM for global variables		 % examples/CAN/WriteCan
flash		 % examples/CAN/WriteCan
RAM for global variables		 % examples/Digital_output
flash		 % examples/Digital_output
RAM for global variables		 % examples/Digital_programmable/Digital_input
flash		 % examples/Digital_programmable/Digital_input
RAM for global variables		 % examples/Digital_programmable/GPIO_programmable
flash		 % examples/Digital_programmable/GPIO_programmable
RAM for global variables		 % examples/Encoders
flash		 % examples/Encoders
RAM for global variables		 % examples/Ethernet
flash		 % examples/Ethernet
RAM for global variables		 % examples/RS232
flash		 % examples/RS232
RAM for global variables		 % examples/RS485_fullduplex
flash		 % examples/RS485_fullduplex
RAM for global variables		 % examples/RS485_halfduplex
flash		 % examples/RS485_halfduplex
RAM for global variables		 % examples/RTC
flash		 % examples/RTC
RAM for global variables		 % examples/RTC_Alarm
flash		 % examples/RTC_Alarm
RAM for global variables		 % examples/Temp_probes_RTD
flash		 % examples/Temp_probes_RTD
RAM for global variables		 % examples/Temp_probes_Thermocouples
flash		 % examples/Temp_probes_Thermocouples
RAM for global variables		 % examples/USB_host
flash		 % examples/USB_host
RAM for global variables		 %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
Click for full report CSV 
Board,examples/Analog_Out<br>flash,%,examples/Analog_Out<br>RAM for global variables,%,examples/Analog_input/Analog_input_0_10V<br>flash,%,examples/Analog_input/Analog_input_0_10V<br>RAM for global variables,%,examples/Analog_input/Analog_input_4_20mA<br>flash,%,examples/Analog_input/Analog_input_4_20mA<br>RAM for global variables,%,examples/Analog_input/Analog_input_NTC<br>flash,%,examples/Analog_input/Analog_input_NTC<br>RAM for global variables,%,examples/Analog_input/Fast_Analog_input_0_10V<br>flash,%,examples/Analog_input/Fast_Analog_input_0_10V<br>RAM for global variables,%,examples/CAN/ReadCan<br>flash,%,examples/CAN/ReadCan<br>RAM for global variables,%,examples/CAN/WriteCan<br>flash,%,examples/CAN/WriteCan<br>RAM for global variables,%,examples/Digital_output<br>flash,%,examples/Digital_output<br>RAM for global variables,%,examples/Digital_programmable/Digital_input<br>flash,%,examples/Digital_programmable/Digital_input<br>RAM for global variables,%,examples/Digital_programmable/GPIO_programmable<br>flash,%,examples/Digital_programmable/GPIO_programmable<br>RAM for global variables,%,examples/Encoders<br>flash,%,examples/Encoders<br>RAM for global variables,%,examples/Ethernet<br>flash,%,examples/Ethernet<br>RAM for global variables,%,examples/RS232<br>flash,%,examples/RS232<br>RAM for global variables,%,examples/RS485_fullduplex<br>flash,%,examples/RS485_fullduplex<br>RAM for global variables,%,examples/RS485_halfduplex<br>flash,%,examples/RS485_halfduplex<br>RAM for global variables,%,examples/RTC<br>flash,%,examples/RTC<br>RAM for global variables,%,examples/RTC_Alarm<br>flash,%,examples/RTC_Alarm<br>RAM for global variables,%,examples/Temp_probes_RTD<br>flash,%,examples/Temp_probes_RTD<br>RAM for global variables,%,examples/Temp_probes_Thermocouples<br>flash,%,examples/Temp_probes_Thermocouples<br>RAM for global variables,%,examples/USB_host<br>flash,%,examples/USB_host<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 21, 2025
leonardocavagnis
leonardocavagnis requested changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@leonardocavagnis leonardocavagnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution!
Minor change request

@github-actions GitHub Actions
Copy link

Memory usage change @ ddb326d

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
Click for full report table
Board examples/Analog_Out
flash		 % examples/Analog_Out
RAM for global variables		 % examples/Analog_input/Analog_input_0_10V
flash		 % examples/Analog_input/Analog_input_0_10V
RAM for global variables		 % examples/Analog_input/Analog_input_4_20mA
flash		 % examples/Analog_input/Analog_input_4_20mA
RAM for global variables		 % examples/Analog_input/Analog_input_NTC
flash		 % examples/Analog_input/Analog_input_NTC
RAM for global variables		 % examples/Analog_input/Fast_Analog_input_0_10V
flash		 % examples/Analog_input/Fast_Analog_input_0_10V
RAM for global variables		 % examples/CAN/ReadCan
flash		 % examples/CAN/ReadCan
RAM for global variables		 % examples/CAN/WriteCan
flash		 % examples/CAN/WriteCan
RAM for global variables		 % examples/Digital_output
flash		 % examples/Digital_output
RAM for global variables		 % examples/Digital_programmable/Digital_input
flash		 % examples/Digital_programmable/Digital_input
RAM for global variables		 % examples/Digital_programmable/GPIO_programmable
flash		 % examples/Digital_programmable/GPIO_programmable
RAM for global variables		 % examples/Encoders
flash		 % examples/Encoders
RAM for global variables		 % examples/Ethernet
flash		 % examples/Ethernet
RAM for global variables		 % examples/RS232
flash		 % examples/RS232
RAM for global variables		 % examples/RS485_fullduplex
flash		 % examples/RS485_fullduplex
RAM for global variables		 % examples/RS485_halfduplex
flash		 % examples/RS485_halfduplex
RAM for global variables		 % examples/RTC
flash		 % examples/RTC
RAM for global variables		 % examples/RTC_Alarm
flash		 % examples/RTC_Alarm
RAM for global variables		 % examples/Temp_probes_RTD
flash		 % examples/Temp_probes_RTD
RAM for global variables		 % examples/Temp_probes_Thermocouples
flash		 % examples/Temp_probes_Thermocouples
RAM for global variables		 % examples/USB_host
flash		 % examples/USB_host
RAM for global variables		 %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
Click for full report CSV 
Board,examples/Analog_Out<br>flash,%,examples/Analog_Out<br>RAM for global variables,%,examples/Analog_input/Analog_input_0_10V<br>flash,%,examples/Analog_input/Analog_input_0_10V<br>RAM for global variables,%,examples/Analog_input/Analog_input_4_20mA<br>flash,%,examples/Analog_input/Analog_input_4_20mA<br>RAM for global variables,%,examples/Analog_input/Analog_input_NTC<br>flash,%,examples/Analog_input/Analog_input_NTC<br>RAM for global variables,%,examples/Analog_input/Fast_Analog_input_0_10V<br>flash,%,examples/Analog_input/Fast_Analog_input_0_10V<br>RAM for global variables,%,examples/CAN/ReadCan<br>flash,%,examples/CAN/ReadCan<br>RAM for global variables,%,examples/CAN/WriteCan<br>flash,%,examples/CAN/WriteCan<br>RAM for global variables,%,examples/Digital_output<br>flash,%,examples/Digital_output<br>RAM for global variables,%,examples/Digital_programmable/Digital_input<br>flash,%,examples/Digital_programmable/Digital_input<br>RAM for global variables,%,examples/Digital_programmable/GPIO_programmable<br>flash,%,examples/Digital_programmable/GPIO_programmable<br>RAM for global variables,%,examples/Encoders<br>flash,%,examples/Encoders<br>RAM for global variables,%,examples/Ethernet<br>flash,%,examples/Ethernet<br>RAM for global variables,%,examples/RS232<br>flash,%,examples/RS232<br>RAM for global variables,%,examples/RS485_fullduplex<br>flash,%,examples/RS485_fullduplex<br>RAM for global variables,%,examples/RS485_halfduplex<br>flash,%,examples/RS485_halfduplex<br>RAM for global variables,%,examples/RTC<br>flash,%,examples/RTC<br>RAM for global variables,%,examples/RTC_Alarm<br>flash,%,examples/RTC_Alarm<br>RAM for global variables,%,examples/Temp_probes_RTD<br>flash,%,examples/Temp_probes_RTD<br>RAM for global variables,%,examples/Temp_probes_Thermocouples<br>flash,%,examples/Temp_probes_Thermocouples<br>RAM for global variables,%,examples/USB_host<br>flash,%,examples/USB_host<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

@leonardocavagnis leonardocavagnis merged commit 0062b27 into arduino-libraries:main Jul 22, 2025
4 checks passed
@jiander-snap jiander-snap deleted the encoder_enhancement branch July 22, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardocavagnis leonardocavagnis leonardocavagnis requested changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiander-snap @CLAassistant @leonardocavagnis @per1234