Skip to content

Conversation

iabdalkader
Copy link

No description provided.

@iabdalkader iabdalkader force-pushed the add_format_check branch 12 times, most recently from 4889d39 to b81681d Compare August 13, 2025 11:10
@iabdalkader iabdalkader changed the title github: Add format check. workflows: Add format check. Aug 14, 2025
@iabdalkader iabdalkader force-pushed the add_format_check branch 3 times, most recently from d17fd74 to f8d6116 Compare August 27, 2025 13:19
@pennam pennam merged commit cb3531e into arduino:main Aug 28, 2025
16 checks passed
@iabdalkader iabdalkader deleted the add_format_check branch August 28, 2025 14:15
@KurtE
Copy link

KurtE commented Aug 28, 2025

Quick Questions:
How does one update the currently Active PRs?

a) There appears to be new requirement for: commit message format... So I change it and it still complains about it?
image

It now still errors on the original commit title and then says that the new one is fine?

image

b) Code formatting. My guess will end up with a large percentage of the changed lines that are part of the PR will show up as conflicts.

Luckily in this case, just one #if line changed.

Suggestions?

@iabdalkader
Copy link
Author

How does one update the currently Active PRs?

You rebase and format.

It now still errors on the original commit title and then says that the new one is fine?

You must also fix your PR title. We'll leave it to @pennam to decided whether keep this on or not (it's the excludeTitle option in the workflow, I think).

@KurtE
Copy link

KurtE commented Aug 28, 2025

You rebase and format.
Yes - was in process of that, but because the clang-format of "this" commit touched all of the lines, it new gives you
conflicts on most of the lines I may have changed as part of the PR... yep luckily hopefully only a major one time hit.

Sorry the commit check did not mention anything about the PR titles... Will change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants