Skip to content

Conversation

@Starlitnightly
Copy link
Collaborator

This pull request adds a new dimension reduction method, SUDE, to the codebase and integrates it into the existing pipeline for dimensionality reduction. The main changes include the addition of the full SUDE algorithm implementation and supporting functions, updating the API to expose SUDE, and modifying documentation to reflect the new option.

SUDE algorithm and supporting functions:

  • Added a complete implementation of the SUDE algorithm in sude.py, including landmark selection, embedding computation, and handling of large datasets.
  • Introduced supporting mathematical and utility functions for SUDE, including init_pca (PCA initialization), pca (PCA embedding), mds (MDS embedding), pps (landmark sampling), learning_s and learning_l (manifold learning for landmarks), opt_scale (optimal landmark scaling), clle (constrained locally linear embedding), and plotcluster2 (embedding visualization).

API and integration updates:

  • Exposed the sude function at the package level by updating the __init__.py file to import it.
  • Updated the main tools API to include run_sude as an available dimension reduction method.
  • Extended the documentation for the reduceDimension function to mention SUDE as a supported reduction method.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds SUDE (Scalable Unsupervised Deep Embedding) as a new dimension reduction method to the Dynamo package. The implementation includes a complete SUDE algorithm with supporting mathematical functions and integrates it into the existing dimension reduction pipeline.

  • Added complete SUDE algorithm implementation with supporting functions for landmark selection, embedding computation, and large dataset handling
  • Integrated SUDE into the main dimension reduction API and exposed it at the package level
  • Added comprehensive test coverage for SUDE functionality including edge cases and parameter validation

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_sude.py Comprehensive test suite covering SUDE functionality, parameter validation, and integration
dynamo/tools/utils_reduceDimension.py Updated to include SUDE as a supported reduction method in the main pipeline
dynamo/tools/dimension_reduction.py Added dedicated run_sude function and updated documentation to mention SUDE support
dynamo/tools/init.py Exposed run_sude function at the package level
dynamo/external/sude_py/*.py Complete SUDE algorithm implementation with supporting mathematical functions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@aristoteleo aristoteleo deleted a comment from Copilot AI Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 84.63203% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.27%. Comparing base (9f82563) to head (751242c).

Files with missing lines Patch % Lines
dynamo/external/sude_py/learning_l.py 84.94% 14 Missing ⚠️
dynamo/external/sude_py/init_pca.py 13.33% 13 Missing ⚠️
dynamo/external/sude_py/plotcluster2.py 0.00% 13 Missing ⚠️
tests/test_sude.py 91.86% 10 Missing ⚠️
dynamo/external/sude_py/learning_s.py 87.14% 9 Missing ⚠️
dynamo/external/sude_py/sude.py 87.23% 6 Missing ⚠️
dynamo/external/sude_py/clle.py 84.61% 2 Missing ⚠️
dynamo/tools/dimension_reduction.py 90.90% 2 Missing ⚠️
dynamo/tools/utils_reduceDimension.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
+ Coverage   36.56%   37.27%   +0.71%     
==========================================
  Files         183      195      +12     
  Lines       35352    35813     +461     
==========================================
+ Hits        12925    13349     +424     
- Misses      22427    22464      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant