Skip to content

Commit a3234d2

Browse files
ortaorta
committed
Make green
1 parent aa74df6 commit a3234d2

23 files changed

+247
-181
lines changed

‎Artsy Tests/ARProfileViewControllerTests.m‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
#import <ARAnalytics/ARAnalytics.h>
44
#import "ARAnalyticsConstants.h"
55
#import "UIViewController+SimpleChildren.h"
6-
#import "UIView+FLKAutoLayout.h"
6+
@import FLKAutoLayout;
77
#import "ARFairViewController.h"
88
#import "ARInternalMobileWebViewController.h"
99

‎Artsy Tests/OCMArg+ClassChecker.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#import "OCMArg.h"
1+
@import OCMock;
22

33
@interface OCMArg (ClassChecker)
44

‎Artsy.xcodeproj/project.pbxproj‎

Lines changed: 96 additions & 44 deletions
Large diffs are not rendered by default.

‎Artsy/Classes/ARAppDelegate.m‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ - (void)fetchSiteFeatures
394394
[ARDefaults setOnboardingDefaults:features];
395395

396396
} failure:^(NSError *error) {
397-
NSLog(@"Couldn't get site features. Error %@", error.localizedDescription);
397+
ARErrorLog(@"Couldn't get site features. Error %@", error.localizedDescription);
398398
}];
399399
}];
400400
}

‎Artsy/Classes/App/ARAppBackgroundFetchDelegate.m‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ + (NSString *)pathForDownloadedShowFeed
1515

1616
- (void)application:(UIApplication *)application performFetchWithCompletionHandler:(void (^)(UIBackgroundFetchResult result))completionHandler
1717
{
18-
NSLog(@"Fetching show feed in the background.");
18+
ARActionLog(@"Fetching show feed in the background.");
1919

2020
[ArtsyAPI getFeedResultsForShowsWithCursor:nil pageSize:10 success:^(NSDictionary *JSON) {
2121
if ([JSON isKindOfClass:[NSDictionary class]]) {
2222

2323
NSString *path = [self.class pathForDownloadedShowFeed];
2424
[NSKeyedArchiver archiveRootObject:JSON toFile:path];
2525

26-
NSLog(@"Downloaded show feed in the background");
26+
ARActionLog(@"Downloaded show feed in the background");
2727

2828
if (completionHandler) {
2929
completionHandler(UIBackgroundFetchResultNewData);
@@ -32,13 +32,13 @@ - (void)application:(UIApplication *)application performFetchWithCompletionHandl
3232
return;
3333
}
3434

35-
NSLog(@"Error feed is in an unexpected format");
35+
ARErrorLog(@"Error feed is in an unexpected format");
3636
if (completionHandler) {
3737
completionHandler(UIBackgroundFetchResultFailed);
3838
}
3939

4040
} failure:^(NSError *error) {
41-
NSLog(@"Error downloading feed from the background : %@", error.localizedDescription);
41+
ARErrorLog(@"Error downloading feed from the background : %@", error.localizedDescription);
4242
if (completionHandler) {
4343
completionHandler(UIBackgroundFetchResultFailed);
4444
}

‎Artsy/Classes/App/ARAppNotificationsDelegate.m‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ + (void)load
1414
- (void)application:(UIApplication *)application didFailToRegisterForRemoteNotificationsWithError:(NSError *)error
1515
{
1616
#if (TARGET_IPHONE_SIMULATOR == 0)
17-
NSLog(@"Error registering for remote notifications: %@", error.localizedDescription);
17+
ARErrorLog(@"Error registering for remote notifications: %@", error.localizedDescription);
1818
#endif
1919
}
2020

@@ -41,7 +41,7 @@ - (void)application:(UIApplication *)application didRegisterForRemoteNotificatio
4141
[ArtsyAPI setAPNTokenForCurrentDevice:deviceToken success:^(id response) {
4242
ARActionLog(@"Pushed device token to Artsy's servers");
4343
} failure:^(NSError *error) {
44-
NSLog(@"Couldn't push the device token to Artsy, error: %@", error.localizedDescription);
44+
ARErrorLog(@"Couldn't push the device token to Artsy, error: %@", error.localizedDescription);
4545
}];
4646
#endif
4747
}

‎Artsy/Classes/Models/ARFeed.m‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ - (NSOrderedSet *)parseItemsFromJSON:(NSDictionary *)result
4747
// Sometimes the cursor is an NSNumber, so stringify it
4848
} else if ([next respondsToSelector:@selector(stringValue)]) {
4949
self.cursor = [next stringValue];
50-
NSLog(@"Got a weird next cursor for the feed but string'd %@ - ", self.cursor);
50+
ARErrorLog(@"Got a weird next cursor for the feed but string'd %@ - ", self.cursor);
5151

5252
} else {
53-
NSLog(@"Got a weird next cursor for the feed %@ - ", self.cursor);
53+
ARErrorLog(@"Got a weird next cursor for the feed %@ - ", self.cursor);
5454
}
5555
}
5656

@@ -63,10 +63,10 @@ - (NSOrderedSet *)parseItemsFromJSON:(NSDictionary *)result
6363
if (!error) {
6464
[objects addObject:object];
6565
} else {
66-
NSLog(@"Error creating %@ - %@", type, error.localizedDescription);
66+
ARErrorLog(@"Error creating %@ - %@", type, error.localizedDescription);
6767
}
6868
} else {
69-
NSLog(@"Unknown feed item type %@! Ignoring!", type);
69+
ARErrorLog(@"Unknown feed item type %@! Ignoring!", type);
7070
}
7171
}
7272

‎Artsy/Classes/Models/ARHeroUnitsNetworkModel.m‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,15 @@ - (void)getHeroUnitsWithSuccess:(void (^)(NSArray *heroUnits))success failure:(v
5050

5151
} failure:^(NSError *error) {
5252
@strongify(self);
53-
NSLog(@"There was an error getting Hero Units: %@", error.localizedDescription);
53+
ARErrorLog(@"There was an error getting Hero Units: %@", error.localizedDescription);
5454
self.isLoading = NO;
5555
if (failure) {
5656
failure(error);
5757
}
5858
}];
5959
} failure:^(NSError *error) {
6060
@strongify(self);
61-
NSLog(@"There was an error getting Hero Units: %@", error.localizedDescription);
61+
ARErrorLog(@"There was an error getting Hero Units: %@", error.localizedDescription);
6262
self.isLoading = NO;
6363
if (failure) {
6464
failure(error);

‎Artsy/Classes/Networking/ARAuthProviders.m‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,14 @@ + (void)getTokenForFacebook:(void (^)(NSString *token, NSString *email, NSString
5858
// NSString *name = user[@"name"];
5959
// success(token, email, name);
6060
// } else {
61-
// NSLog(@"Couldn't get user info from Facebook");
61+
// ARErrorLog(@"Couldn't get user info from Facebook");
6262
// failure(error);
6363
// }
6464
// }];
6565
// } else {
6666
// NSString *description = error ? [error description] : @"token was nil";
6767
// [ARAnalytics event:ARAnalyticsErrorFailedToGetFacebookCredentials withProperties:@{ @"error" : description }];
68-
// NSLog(@"Couldn't get Facebook credentials");
68+
// ARErrorLog(@"Couldn't get Facebook credentials");
6969
// failure(error);
7070
// }
7171
// }];

‎Artsy/Classes/Networking/Network Models/ARFollowableNetworkModel.m‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ - (id)initWithFollowableObject:(id <ARFollowable>)representedObject
2121
self->_following = (status == ARHeartStatusYes);
2222
[self didChangeValueForKey:@"following"];
2323
} failure:^(NSError *error) {
24-
NSLog(@"Error checking follow status for %@ - %@", self.representedObject, error.localizedDescription);
24+
ARErrorLog(@"Error checking follow status for %@ - %@", self.representedObject, error.localizedDescription);
2525
}];
2626

2727
return self;
@@ -35,14 +35,14 @@ - (void)setFollowing:(BOOL)following
3535
if(following){
3636
[_representedObject followWithSuccess:nil failure:^(NSError *error) {
3737
@strongify(self);
38-
NSLog(@"Error following %@ - %@", self.representedObject, error.localizedDescription);
38+
ARErrorLog(@"Error following %@ - %@", self.representedObject, error.localizedDescription);
3939
[self _setFollowing:NO];
4040
}];
4141

4242
} else {
4343
[_representedObject unfollowWithSuccess:nil failure:^(NSError *error) {
4444
@strongify(self);
45-
NSLog(@"Error following %@ - %@", self.representedObject, error.localizedDescription);
45+
ARErrorLog(@"Error following %@ - %@", self.representedObject, error.localizedDescription);
4646
[self _setFollowing:YES];
4747
}];
4848
}

0 commit comments

Comments
 (0)