Skip to content

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Nov 24, 2025

See #863 (comment)

Closes #863

@zanieb zanieb added the platform:darwin Specific to the macOS platform label Nov 24, 2025
@zanieb
Copy link
Member Author

zanieb commented Nov 24, 2025

@copilot edit this to retain the patch for 3.13 but drop it for 3.14+

Copy link

Copilot AI commented Nov 24, 2025

@zanieb I've opened a new pull request, #888, to work on those changes. Once the pull request is ready, I'll request review from you.

Retains the `patch-apple-cross` patch for Python 3.13 but drops it for
3.14+, where the upstream configure script now supports cross-compiling
on Apple.

- Changed version check from `PYTHON_MEETS_MAXIMUM_VERSION_3_12` to
`PYTHON_MEETS_MAXIMUM_VERSION_3_13` in `cpython-unix/build-cpython.sh`
- Restored `patch-apple-cross-3.13.patch` for Python 3.13
- Updated build script to use version-specific patches:
  - 3.10, 3.11: `patch-apple-cross.patch`
  - 3.12: `patch-apple-cross-3.12.patch`
  - 3.13: `patch-apple-cross-3.13.patch`
  - 3.14+: No patch applied

<!-- START COPILOT CODING AGENT TIPS -->
---

💬 We'd love your input! Share your thoughts on Copilot coding agent in
our [2 minute survey](https://gh.io/copilot-coding-agent-survey).

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: zanieb <[email protected]>
@zanieb zanieb changed the title Drop patch-apple-cross on 3.13+ Drop patch-apple-cross on 3.14+ Nov 24, 2025
@zanieb zanieb marked this pull request as ready for review November 24, 2025 23:59
@zanieb zanieb requested a review from jjhelmus November 25, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform:darwin Specific to the macOS platform python:3.13 python:3.14

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upstream patch patch-apple-cross-3.13.patch

2 participants