Merge pull request #306 from atlassian/ARC-3241-clean-bulkbyproperties

yvonnevictoria · web-flow · commit 60c404791ca5 · 2024-08-07T15:45:16.000+10:00
ARC-3241 Clean BulkByProperties api call to remove cloud id as this is redundant
diff --git a/app/src/jira-client/delete-builds.ts b/app/src/jira-client/delete-builds.ts
@@ -15,7 +15,7 @@ async function deleteBuilds(cloudId: string, jenkinsServerUuid?: string): Promis
 	let deleteBuildsRoute: Route;
 	if (jenkinsServerUuid) {
 		// eslint-disable-next-line max-len
-		deleteBuildsRoute = route`/builds/0.1/cloud/${cloudId}/bulkByProperties?cloudId=${cloudId}&jenkinsServerUuid=${jenkinsServerUuid}`;
+		deleteBuildsRoute = route`/builds/0.1/cloud/${cloudId}/bulkByProperties?jenkinsServerUuid=${jenkinsServerUuid}`;
 	} else {
 		deleteBuildsRoute = route`/builds/0.1/cloud/${cloudId}/bulkByProperties?cloudId=${cloudId}`;
 	}

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ async function deleteBuilds(cloudId: string, jenkinsServerUuid?: string): Promis`
`15`	`15`	`let deleteBuildsRoute: Route;`
`16`	`16`	`if (jenkinsServerUuid) {`
`17`	`17`	`// eslint-disable-next-line max-len`
`18`		- deleteBuildsRoute = route`/builds/0.1/cloud/${cloudId}/bulkByProperties?cloudId=${cloudId}&jenkinsServerUuid=${jenkinsServerUuid}`;
	`18`	+ deleteBuildsRoute = route`/builds/0.1/cloud/${cloudId}/bulkByProperties?jenkinsServerUuid=${jenkinsServerUuid}`;
`19`	`19`	`} else {`
`20`	`20`	deleteBuildsRoute = route`/builds/0.1/cloud/${cloudId}/bulkByProperties?cloudId=${cloudId}`;
`21`	`21`	`}`