Do not redirect language server stderr.

Author: autozimu

src/languageclient.rs

@@ -2440,15 +2440,12 @@ impl State {
                     })
                     .collect();
 
-                let stderr = logger::open(&get_logpath_server())?;
-
                 let process = std::process::Command::new(command
                     .get(0)
                     .ok_or_else(|| err_msg("Empty command!"))?)
                     .args(&command[1..])
                     .stdin(Stdio::piped())
                     .stdout(Stdio::piped())
-                    .stderr(stderr)
                     .spawn()?;
 
                 let child_id = Some(process.id());

src/logger.rs

@@ -26,14 +26,6 @@ fn create_config(path: &Option<String>, level: &LevelFilter) -> Result<Config> {
     Ok(config)
 }
 
-pub fn open<P: AsRef<Path>>(path: P) -> Result<File> {
-    let mut fo = std::fs::OpenOptions::new();
-    let fo = fo.create(true).write(true).truncate(true);
-    #[cfg(unix)]
-    let fo = fo.mode(0o666);
-    Ok(fo.open(path)?)
-}
-
 pub fn init() -> Result<Handle> {
     let handle = log4rs::init_config(create_config(&None, &LevelFilter::Warn)?)?;
 

src/main.rs

@@ -1,6 +1,5 @@
 #![allow(non_snake_case, non_upper_case_globals, unknown_lints)]
 
-use std::borrow::Cow;
 use std::collections::{HashMap, HashSet, VecDeque};
 use std::convert::Into;
 use std::env;
@@ -10,9 +9,6 @@ use std::io::prelude::*;
 use std::io::{BufRead, BufReader, BufWriter};
 use std::net::TcpStream;
 use std::ops::Deref;
-#[allow(unused_imports)]
-#[cfg(unix)]
-use std::os::unix::fs::OpenOptionsExt;
 use std::path::{Path, PathBuf};
 use std::process::{ChildStdin, ChildStdout, Stdio};
 use std::str::FromStr;

src/utils.rs

@@ -126,22 +126,6 @@ impl<P: AsRef<Path> + std::fmt::Debug> ToUrl for P {
     }
 }
 
-pub fn get_tmppath() -> PathBuf {
-    // Ref: https://en.wikipedia.org/wiki/TMPDIR
-    let dir: Cow<_> = env::var("TMPDIR")
-        .or_else(|_| env::var("TMP"))
-        .or_else(|_| env::var("TEMP"))
-        .or_else(|_| env::var("TEMPDIR"))
-        .map(|t| t.into())
-        .unwrap_or_else(|_| "/tmp".into());
-
-    PathBuf::from(&*dir)
-}
-
-pub fn get_logpath_server() -> PathBuf {
-    get_tmppath().join("LanguageServer.log")
-}
-
 pub fn apply_TextEdits(lines: &[String], edits: &[TextEdit]) -> Result<Vec<String>> {
     // Edits are ordered from bottom to top, from right to left.
     let mut edits_by_index = vec![];

src/vim.rs

@@ -356,13 +356,7 @@ pub fn loop_reader<T: BufRead>(
             if line.is_empty() {
                 count_empty_lines += 1;
                 if count_empty_lines > 5 {
-                    let mut message = "".to_string();
-                    if let Ok(log_server) = read_to_string(get_logpath_server()) {
-                        message += "\n\nlanguage server stderr:\n";
-                        message += &log_server;
-                    }
-
-                    bail!("{}", message);
+                    bail!("Unable to read from language server");
                 }
 
                 let mut buf = vec![0; content_length];