Skip to content

Commit 28b8013

Browse files
authored
chore: make cleanup a bit safer (#3346)
I have observed a lot of occasions where tests are being disturbed because resources are being deleted out from under them; either buckets or roles are being deletd while they are still being deployed. - List all resources in CloudFormation, and avoid hard-deleting any resource that is still managed by a CloudFormation stack. - In this PR, extend the notion of "staleness" (older than X hours) to stacks and apps, so we don't delete stacks and apps that might potentially still have tests running on them. - Increase the staleness period a little, because I've seen cleanup be too eager. - Put some time-traceability into the cleanup session's name, so we can start debugging a little easier than with just a random number.
1 parent af186d5 commit 28b8013

File tree

4 files changed

+289
-83
lines changed

4 files changed

+289
-83
lines changed

packages/amplify-e2e-tests/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
"@aws-sdk/client-amplify": "^3.812.0",
4242
"@aws-sdk/client-sts": "^3.812.0",
4343
"@aws-sdk/client-organizations": "^3.812.0",
44+
"@smithy/util-retry": "^4.1.2",
4445
"amplify-category-api-e2e-core": "5.0.9",
4546
"aws-amplify": "^4.2.8",
4647
"aws-appsync": "^4.1.1",

0 commit comments

Comments
 (0)